Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

virtiofs: virtiofs mount inside guest hangs if virtiofsd quits #2315

Closed
eryugey opened this issue Dec 4, 2019 · 0 comments · Fixed by #2316
Closed

virtiofs: virtiofs mount inside guest hangs if virtiofsd quits #2315

eryugey opened this issue Dec 4, 2019 · 0 comments · Fixed by #2316
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.

Comments

@eryugey
Copy link
Contributor

eryugey commented Dec 4, 2019

Description of problem

If virtiofsd was dead, the virtiofs mount inside guest hangs.

Commit 89e0dfa ("qemu: stop qemu process when virtiofsd quits") fixed it once. But commit d5a3d0a ("virtiofs: use virtiofsd --fd=FDNUM") broke it.

Expected result

sandbox is stopped as well.

Actual result

virtiofs mount hangs inside guest.

Additional info

I'll send a PR to fix this issue

@eryugey eryugey added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Dec 4, 2019
eryugey added a commit to eryugey/runtime that referenced this issue Dec 4, 2019
Commit 89e0dfa ("qemu: stop qemu process when virtiofsd quits")
stops sandbox when virtiofsd quits so that virtiofs mount inside guest
won't hang. But commit d5a3d0a ("virtiofs: use virtiofsd
--fd=FDNUM") deleted this monitor logic.

Add the Scanner back to monitor virtiofsd's stderr and stop sandbox if
Scanner returns error.

Note that we don't monitor the virtiofsd process itself is because
virtiofsd may be live-upgraded (when available) and the original
process may quit, but virtiofs service is still running.

Fixes: kata-containers#2315
Signed-off-by: Eryu Guan <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant