Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

clh: Update client based in versions.yaml #2341

Closed
jcvenegas opened this issue Dec 10, 2019 · 0 comments · Fixed by #2342
Closed

clh: Update client based in versions.yaml #2341

jcvenegas opened this issue Dec 10, 2019 · 0 comments · Fixed by #2342
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.

Comments

@jcvenegas
Copy link
Member

Which feature do you think can be improved?

The way to update cloud hypervisor client is done via master but should point to what we define in versions.yaml

How can it be improved?

https://github.com/kata-containers/runtime/blob/master/virtcontainers/pkg/cloud-hypervisor/Makefile use yq to get the hypervisor version.

Additional Information

Anything else to add?

Before raising this feature request

Have you looked at the limitations document?
@jcvenegas jcvenegas added enhancement Improvement to an existing feature needs-review Needs to be assessed by the team. labels Dec 10, 2019
jcvenegas added a commit to jcvenegas/runtime that referenced this issue Dec 10, 2019
@jcvenegas
clh: client: update acording to versions.yaml
efb611a 
Instead of point to master use the version defined
in versions.yaml

Fixes: kata-containers#2341

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
@jcvenegas jcvenegas mentioned this issue Dec 10, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

clh: client: update acording to versions.yaml jcvenegas/runtime
1 participant
@jcvenegas