Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

s390x: image option is broken #2384

Closed
alicefr opened this issue Jan 9, 2020 · 0 comments · Fixed by #2385
Closed

s390x: image option is broken #2384

alicefr opened this issue Jan 9, 2020 · 0 comments · Fixed by #2385
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.

Comments

@alicefr
Copy link

alicefr commented Jan 9, 2020

Hi,

the imageoption for the root filesystem of the VM is broken. This commit dd5b446 removed the appendImage from the virtcontainer/qemu_s390x.go and now it uses the arch base function. The required devno param is not set it. I'm fixing that.

@alicefr alicefr added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Jan 9, 2020
alicefr pushed a commit to alicefr/runtime that referenced this issue Jan 9, 2020
On s390x we need to set the devno.

Fixes: kata-containers#2384

Signed-off-by: Alice Frosi <[email protected]>
alicefr pushed a commit to alicefr/runtime that referenced this issue Jan 9, 2020
On s390x we need to set the devno that's why we need a custom
appendBlkDevice function.

Fixes: kata-containers#2384

Signed-off-by: Alice Frosi <[email protected]>
alicefr pushed a commit to alicefr/runtime that referenced this issue Jan 9, 2020
On s390x we need to set the devno that's why we need a custom
appendBlkDevice function.

Fixes: kata-containers#2384

Signed-off-by: Alice Frosi <[email protected]>
dong-liuliu pushed a commit to dong-liuliu/runtime that referenced this issue Feb 8, 2020
On s390x we need to set the devno that's why we need a custom
appendBlkDevice function.

Fixes: kata-containers#2384

Signed-off-by: Alice Frosi <[email protected]>
evanfoster pushed a commit to evanfoster/runtime that referenced this issue Mar 9, 2020
On s390x we need to set the devno that's why we need a custom
appendBlkDevice function.

Fixes: kata-containers#2384

Signed-off-by: Alice Frosi <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant