-
Notifications
You must be signed in to change notification settings - Fork 373
ci: fix issues introduced by Go 1.10 #249
Comments
Now that our CI has moved to Go 1.10, we need to update one file that is not formatted as the new gofmt (1.10) expects it to be formatted. Fixes kata-containers#249 Signed-off-by: Sebastien Boeuf <[email protected]>
Can we have a CI policy in place that any change in CI should pass proper CI first? I hope that we are not performing a test-driven development by merging tests first and catching up with code change. |
Created kata-containers/tests/issues/258 to enforce such a policy. |
@bergwolf the CI always gates any PR from being merged. The problem we have/had here is that we switched the Go version directly on the Jenkins server scripts, and no PR is needed for this... |
yes, sorry for this, we will be using a script on |
Now that our CI has moved to Go 1.10, we need to update one file that is not formatted as the new gofmt (1.10) expects it to be formatted. Fixes kata-containers#249 Signed-off-by: Sebastien Boeuf <[email protected]>
Now that our CI has moved to Go 1.10, we need to update one file that is not formatted as the new gofmt (1.10) expects it to be formatted. Fixes kata-containers#249 Signed-off-by: Sebastien Boeuf <[email protected]>
Now that our CI has moved to Go 1.10, we need to update one file that is not formatted as the new gofmt (1.10) expects it to be formatted. Fixes kata-containers#249 Signed-off-by: Sebastien Boeuf <[email protected]>
namespaces: Create persistent UTS and IPC namespaces
Now that our CI has moved to Go 1.10, we need to update one file that is not formatted as the new
gofmt
(1.10) expects it to be formatted.The text was updated successfully, but these errors were encountered: