Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

ci: fix issues introduced by Go 1.10 #249

Closed
sboeuf opened this issue Apr 24, 2018 · 4 comments
Closed

ci: fix issues introduced by Go 1.10 #249

sboeuf opened this issue Apr 24, 2018 · 4 comments

Comments

@sboeuf
Copy link

sboeuf commented Apr 24, 2018

Now that our CI has moved to Go 1.10, we need to update one file that is not formatted as the new gofmt (1.10) expects it to be formatted.

sboeuf pushed a commit to sboeuf/runtime-1 that referenced this issue Apr 24, 2018
Now that our CI has moved to Go 1.10, we need to update one file
that is not formatted as the new gofmt (1.10) expects it to be
formatted.

Fixes kata-containers#249

Signed-off-by: Sebastien Boeuf <[email protected]>
@bergwolf
Copy link
Member

Can we have a CI policy in place that any change in CI should pass proper CI first? I hope that we are not performing a test-driven development by merging tests first and catching up with code change.

@bergwolf
Copy link
Member

Created kata-containers/tests/issues/258 to enforce such a policy.

@sboeuf
Copy link
Author

sboeuf commented Apr 24, 2018

@bergwolf the CI always gates any PR from being merged. The problem we have/had here is that we switched the Go version directly on the Jenkins server scripts, and no PR is needed for this...
@jcvenegas @chavafg I think we should make sure that we can setup the Go version from the test scripts we have into github.com/kata-containers/tests, otherwise next Go version switch will cause the same trouble.

@sboeuf sboeuf changed the title virtcontainers: fix gofmt expectations for Go 1.10 ci: fix issues introduced by Go 1.10 Apr 24, 2018
@chavafg
Copy link
Contributor

chavafg commented Apr 24, 2018

yes, sorry for this, we will be using a script on kata-containers/tests (see kata-containers/tests#255) that will install the go version in versions.yaml file. I see that we have switched again to 1.9 for the moment. We should also update https://github.com/kata-containers/runtime/blob/master/versions.yaml#L136 to 1.9 instead of 1.10, at least until we fix the issues with go1.10.

jcvenegas pushed a commit to jcvenegas/runtime that referenced this issue Apr 25, 2018
Now that our CI has moved to Go 1.10, we need to update one file
that is not formatted as the new gofmt (1.10) expects it to be
formatted.

Fixes kata-containers#249

Signed-off-by: Sebastien Boeuf <[email protected]>
jcvenegas pushed a commit to jcvenegas/runtime that referenced this issue Apr 25, 2018
Now that our CI has moved to Go 1.10, we need to update one file
that is not formatted as the new gofmt (1.10) expects it to be
formatted.

Fixes kata-containers#249

Signed-off-by: Sebastien Boeuf <[email protected]>
jcvenegas pushed a commit to jcvenegas/runtime that referenced this issue Apr 25, 2018
Now that our CI has moved to Go 1.10, we need to update one file
that is not formatted as the new gofmt (1.10) expects it to be
formatted.

Fixes kata-containers#249

Signed-off-by: Sebastien Boeuf <[email protected]>
zklei pushed a commit to zklei/runtime that referenced this issue Jun 13, 2019
namespaces: Create persistent UTS and IPC namespaces
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants