Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

API: support sandbox monitor operation #251

Closed
bergwolf opened this issue Apr 24, 2018 · 0 comments
Closed

API: support sandbox monitor operation #251

bergwolf opened this issue Apr 24, 2018 · 0 comments
Assignees

Comments

@bergwolf
Copy link
Member

As described in the API design, we need to support Sandbox.Monitor() operation that returns an error channel for the caller to watch on sandbox fetal errors.

bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Apr 24, 2018
It monitors the sandbox status and returns an error channel to let
caller watch it.

Fixes: kata-containers#251

Signed-off-by: Peng Tao <[email protected]>
bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Apr 24, 2018
It monitors the sandbox status and returns an error channel to let
caller watch it.

Fixes: kata-containers#251

Signed-off-by: Peng Tao <[email protected]>
bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Apr 25, 2018
It monitors the sandbox status and returns an error channel to let
caller watch it.

Fixes: kata-containers#251

Signed-off-by: Peng Tao <[email protected]>
bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Apr 25, 2018
It monitors the sandbox status and returns an error channel to let
caller watch it.

Fixes: kata-containers#251

Signed-off-by: Peng Tao <[email protected]>
bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Apr 26, 2018
It monitors the sandbox status and returns an error channel to let
caller watch it.

Fixes: kata-containers#251

Signed-off-by: Peng Tao <[email protected]>
bergwolf added a commit to bergwolf/kata-runtime that referenced this issue May 1, 2018
It monitors the sandbox status and returns an error channel to let
caller watch it.

Fixes: kata-containers#251

Signed-off-by: Peng Tao <[email protected]>
@sboeuf sboeuf removed the review label May 1, 2018
zklei pushed a commit to zklei/runtime that referenced this issue Jun 13, 2019
Pid namespace is not shared by default. This is a
configuration option for k8s with the cri-o and cri
runtimes. However this information is not available
with these runtimes at the time the sandbox is created.

Introduce a new field "SandnoxPidNs" in CreateContainer
request similar to CreateSandbox request. If this field
is set in CreateContainer request but not in the CreatSandbox
request, it means that pause process has not been created
by the agent. Treat the first container as the infra container
and use the pid namespace of the infra container as the shared
pid namespace to join to. This is inline with current approach
taken by cri-o and cri-containerd.

Fixes kata-containers#251

Signed-off-by: Archana Shinde <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants