Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Makefile: Allow define default hypervisor via env variable #2565

Closed
jcvenegas opened this issue Mar 26, 2020 · 0 comments · Fixed by #2566
Closed

Makefile: Allow define default hypervisor via env variable #2565

jcvenegas opened this issue Mar 26, 2020 · 0 comments · Fixed by #2566
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.

Comments

@jcvenegas
Copy link
Member

Which feature do you think can be improved?

Build and installation to set default hypervisor via env variable

How can it be improved?

make DEFAULT_HYPEVISOR=cloud-hypervisor
make
sudo -E make install

Should install cloud-hypervisor as default

Additional Information

Anything else to add?

Before raising this feature request

Have you looked at the limitations document?
@jcvenegas jcvenegas added enhancement Improvement to an existing feature needs-review Needs to be assessed by the team. labels Mar 26, 2020
jcvenegas added a commit to jcvenegas/runtime that referenced this issue Mar 26, 2020
@jcvenegas
Makefile: Allow change default hypervisor via env var
7997218 
- Add support to change default hypervisor via env variable.

- Show in the summary the default hypervisor to be used.

```
export DEFAULT_HYPEVISOR=cloud-hypervisor
make
sudo -E make install
```

Fixes: kata-containers#2565

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
@jcvenegas jcvenegas mentioned this issue Mar 26, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Makefile: Allow change default hypervisor via env var jcvenegas/runtime
1 participant
@jcvenegas