Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

clh: Enable disk block device hotplug support #2570

Closed
jcvenegas opened this issue Mar 26, 2020 · 1 comment · Fixed by #2681
Closed

clh: Enable disk block device hotplug support #2570

jcvenegas opened this issue Mar 26, 2020 · 1 comment · Fixed by #2681
Assignees
@likebreath
Labels
feature New functionality high-priority Very urgent issue (resolve quickly) needs-review Needs to be assessed by the team.

Comments

@jcvenegas
Copy link
Member

Is your feature request related to a problem? Please describe.

Cloud-hypervisor recently added support to hotplug block devices this will allow to add instead of use virtiofs for some use cases

Describe the solution you'd like

Use cloud-hypervisor API in the case where a block device is added by vircontainers clh implementation.
@jcvenegas jcvenegas added feature New functionality needs-review Needs to be assessed by the team. labels Mar 26, 2020
@likebreath likebreath mentioned this issue Mar 26, 2020
Closed
13 tasks
@jcvenegas jcvenegas added the high-priority Very urgent issue (resolve quickly) label Mar 27, 2020
This was referenced Mar 30, 2020
Closed
Closed
@jcvenegas jcvenegas mentioned this issue Apr 6, 2020
Closed
@likebreath likebreath changed the title clh: Enable block device support clh: Enable disk block device hotplug support May 12, 2020
likebreath added a commit to likebreath/kata-runtime that referenced this issue May 12, 2020
@likebreath
clh: Enable disk block device hotplug support
e7db5fe 
With this patch, the container image can be shared from host with guest
as a block device when the 'devicemapper' is used as the storage driver
for docker. Note: The 'block_device_driver="virtio-blk"' entry is
required in the hypervisor config file to work properly.

Fixes: kata-containers#2570

Signed-off-by: Bo Chen <[email protected]>
@likebreath
Copy link
Contributor

@jcvenegas I finally made the disk block device hotplug work. I turned that the failing was caused by the wrong hypervisor configuration: we need to use "virtio-blk" instead of "virtio-scsi" with clh. I will need your input on how I should add this config change in the runtime repo. Also, it was fun to follow the code paths from container and device modules... I finally read quite some code output the clh driver... :)

likebreath added a commit to likebreath/kata-runtime that referenced this issue May 12, 2020
@likebreath
clh: Set 'virtio-blk' as the default block device driver
77b174c 
The block device driver defaults to 'virtio-scsi' when it is not set in
the hypervisor configuration file, while cloud-hypervisor supports only
'virtio-blk' for its block devices.

Fixes: kata-containers#2570

Signed-off-by: Bo Chen <[email protected]>
@likebreath likebreath mentioned this issue May 12, 2020
Merged
likebreath added a commit to likebreath/kata-runtime that referenced this issue May 12, 2020
@likebreath
clh: Enable disk block device hotplug support
25d4b9b 
With this patch, the container image can be shared from host with guest
as a block device when the 'devicemapper' is used as the storage driver
for docker. Note: The 'block_device_driver="virtio-blk"' entry is
required in the hypervisor config file to work properly.

Fixes: kata-containers#2570

Signed-off-by: Bo Chen <[email protected]>
likebreath added a commit to likebreath/kata-runtime that referenced this issue May 12, 2020
@likebreath
clh: Set 'virtio-blk' as the default block device driver
966be3e 
The block device driver defaults to 'virtio-scsi' when it is not set in
the hypervisor configuration file, while cloud-hypervisor supports only
'virtio-blk' for its block devices.

Fixes: kata-containers#2570

Signed-off-by: Bo Chen <[email protected]>
likebreath added a commit to likebreath/kata-runtime that referenced this issue May 13, 2020
@likebreath
clh: Enable disk block device hotplug support
5e6bcd4 
With this patch, the container image can be shared from host with guest
as a block device when the 'devicemapper' is used as the storage driver
for docker. Note: The 'block_device_driver="virtio-blk"' entry is
required in the hypervisor config file to work properly.

Fixes: kata-containers#2570

Signed-off-by: Bo Chen <[email protected]>
likebreath added a commit to likebreath/kata-runtime that referenced this issue May 13, 2020
@likebreath
clh: Set 'virtio-blk' as the default block device driver
ea0365a 
The block device driver defaults to 'virtio-scsi' when it is not set in
the hypervisor configuration file, while cloud-hypervisor supports only
'virtio-blk' for its block devices.

Fixes: kata-containers#2570

Signed-off-by: Bo Chen <[email protected]>
likebreath added a commit to likebreath/kata-runtime that referenced this issue May 13, 2020
@likebreath
clh: Enable disk block device hotplug support
c5f97b2 
With this patch, the container image can be shared from host with guest
as a block device when the 'devicemapper' is used as the storage driver
for docker. Note: The 'block_device_driver="virtio-blk"' entry is
required in the hypervisor config file to work properly.

Fixes: kata-containers#2570

Signed-off-by: Bo Chen <[email protected]>
likebreath added a commit to likebreath/kata-runtime that referenced this issue May 13, 2020
@likebreath
clh: Set 'virtio-blk' as the default block device driver
5e55272 
The block device driver defaults to 'virtio-scsi' when it is not set in
the hypervisor configuration file, while cloud-hypervisor supports only
'virtio-blk' for its block devices.

Fixes: kata-containers#2570

Signed-off-by: Bo Chen <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@likebreath likebreath

Labels
feature New functionality high-priority Very urgent issue (resolve quickly) needs-review Needs to be assessed by the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

clh: Enable disk block device hotplug support likebreath/kata-runtime
2 participants
@likebreath @jcvenegas