This repository has been archived by the owner on May 12, 2021. It is now read-only.
virtcontainers: always pass sandbox as pointers #262
Comments
bergwolf
added a commit
to bergwolf/kata-runtime
that referenced
this issue
Apr 26, 2018
Currently we sometimes pass it as a pointer and other times not. As a result, the view of sandbox across virtcontainers may not be the same and it costs extra memory copy each time we pass it by value. Fix it by ensuring sandbox is always passed by pointers. Fixes: kata-containers#262 Signed-off-by: Peng Tao <[email protected]>
bergwolf
added a commit
to bergwolf/kata-runtime
that referenced
this issue
May 1, 2018
Currently we sometimes pass it as a pointer and other times not. As a result, the view of sandbox across virtcontainers may not be the same and it costs extra memory copy each time we pass it by value. Fix it by ensuring sandbox is always passed by pointers. Fixes: kata-containers#262 Signed-off-by: Peng Tao <[email protected]>
zklei
pushed a commit
to zklei/runtime
that referenced
this issue
Jun 13, 2019
When agent runs as init process cgroup fs is mounted at /proc, OnlineCPUMem must be able to support both paths, /proc and /sys/fs. fixes kata-containers#262 Signed-off-by: Julio Montes <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We have a lot of copies of sandbox around and it waste time and memory to do so. Instead, we can always pass it as pointers and it also ensures we have a consistent view of sandbox everywhere.
The text was updated successfully, but these errors were encountered: