Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

virtcontainers: GetOOMEvent make agent's goroutines leak #2695

Closed
liubin opened this issue May 21, 2020 · 0 comments · Fixed by #2696
Closed

virtcontainers: GetOOMEvent make agent's goroutines leak #2695

liubin opened this issue May 21, 2020 · 0 comments · Fixed by #2696
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.

Comments

@liubin
Copy link
Member

liubin commented May 21, 2020

Description of problem

Running the latest kata for some while, goroutines in agent will increasing continuously, about 1 goroutine per minute.

And it also produced many too many logs:

May 21 09:36:00 master kata[30282]: time="2020-05-21T09:36:00.669881517Z" level=warning msg="failed to get OOM event from sandbox" error="rpc error: code = DeadlineExceeded desc = context deadline exceeded" sandbox=866635a11e6c426bf4ddf57c8d05ce9fa894e00eb7ae6b8ac9fb3546a07cf86b

Expected result

Goroutines in agent should keep in a stable number.

Reason

GetOOMEvent rpc call used 60 seconds as timeout:

https://github.com/kata-containers/runtime/blob/master/virtcontainers/kata_agent.go#L2015

And code in agent will blocked at https://github.com/kata-containers/agent/blob/master/grpc.go#L1807

@liubin liubin added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels May 21, 2020
liubin added a commit to liubin/runtime that referenced this issue May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant