Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

the error return from GetAndSetSandboxBlockIndex() should be checked #2726

Closed
tedyu opened this issue Jun 3, 2020 · 0 comments · Fixed by #2725
Closed

the error return from GetAndSetSandboxBlockIndex() should be checked #2726

tedyu opened this issue Jun 3, 2020 · 0 comments · Fixed by #2725
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.

Comments

@tedyu
Copy link
Contributor

tedyu commented Jun 3, 2020

Description of problem

In Acrn#appendImage(), we should check the error return value from GetAndSetSandboxBlockIndex().

Expected result

Error from GetAndSetSandboxBlockIndex() should result in Acrn#appendImage() returning error.

Actual result
@tedyu tedyu added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Jun 3, 2020
@tedyu tedyu mentioned this issue Jun 3, 2020
Merged
tedyu added a commit to tedyu/runtime that referenced this issue Jun 3, 2020
@tedyu
virtcontainers: check the error return from GetAndSetSandboxBlockIndex()
48f9d55 
Fixes kata-containers#2726

Signed-off-by: Ted Yu <[email protected]>
tedyu added a commit to tedyu/runtime that referenced this issue Jun 5, 2020
@tedyu
virtcontainers: drop deferred func for GetAndSetSandboxBlockIndex
49ebaa8 
Fixes kata-containers#2726

Signed-off-by: Ted Yu <[email protected]>
fidencio pushed a commit to fidencio/kata-runtime that referenced this issue Jun 10, 2020
@tedyu @fidencio
virtcontainers: drop deferred func for GetAndSetSandboxBlockIndex
af4b51c 
Fixes kata-containers#2726

Signed-off-by: Ted Yu <[email protected]>
(cherry picked from commit 49ebaa8)
@fidencio fidencio mentioned this issue Jun 10, 2020
Merged
fidencio pushed a commit to fidencio/kata-runtime that referenced this issue Jun 24, 2020
@tedyu @fidencio
virtcontainers: drop deferred func for GetAndSetSandboxBlockIndex
857d138 
Fixes kata-containers#2726

Signed-off-by: Ted Yu <[email protected]>
(cherry picked from commit 49ebaa8)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

virtcontainers: drop deferred func for GetAndSetSandboxBlockIndex() tedyu/runtime
1 participant
@tedyu