Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Ineffective error variable check for sandbox creation #2759

Closed
tedyu opened this issue Jun 10, 2020 · 0 comments
Closed

Ineffective error variable check for sandbox creation #2759

tedyu opened this issue Jun 10, 2020 · 0 comments
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.

Comments

@tedyu
Copy link
Contributor

tedyu commented Jun 10, 2020

Description of problem

In newSandbox(), the deferred func checks err variable which is different from the one declared within the useOldStore(ctx) case.

Expected result

Deferred func should correctly respond to non-nil error return.

Actual result
@tedyu tedyu added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Jun 10, 2020
@tedyu tedyu mentioned this issue Jun 10, 2020
Merged
fidencio pushed a commit to fidencio/kata-runtime that referenced this issue Jun 10, 2020
@tedyu @fidencio
virtcontainers: Check the correct error variable for sandbox creation
7b7a4fa 
This PR makes the deferred func check the correct error variable.

Fixes kata-containers#2759

Signed-off-by: Ted Yu <[email protected]>
(cherry picked from commit 2c34263)
@fidencio fidencio mentioned this issue Jun 10, 2020
Merged
fidencio pushed a commit to fidencio/kata-runtime that referenced this issue Jun 24, 2020
@tedyu @fidencio
virtcontainers: Check the correct error variable for sandbox creation
a254da6 
This PR makes the deferred func check the correct error variable.

Fixes kata-containers#2759

Signed-off-by: Ted Yu <[email protected]>
(cherry picked from commit 2c34263)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tedyu