Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

systemd cgroup paths not being handled correctly #2818

Closed
egernst opened this issue Jul 8, 2020 · 1 comment
Closed

systemd cgroup paths not being handled correctly #2818

egernst opened this issue Jul 8, 2020 · 1 comment
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.

Comments

@egernst
Copy link
Member

egernst commented Jul 8, 2020

Description of problem

We currently fail to support systemd managed cgroups on the host (at least when sandbox cgroups only is utilized). We should auto-detect the cgroup manager being used on the system, and properly create sandbox cgroup accordingly.

We should be able to detect based on the format of the path being provided.

Expected result

A cgroup created under the system.slice for the appropriate subsystems, ie in docker case something like:

systemd.slice/docker-SHA

Actual result

Group created next to system.slice of format system.slice:docker:SHA

@egernst egernst added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Jul 8, 2020
@egernst
Copy link
Member Author

egernst commented Jul 8, 2020

/cc @amshinde @devimc @jcvenegas

fidencio pushed a commit to fidencio/kata-runtime that referenced this issue Sep 7, 2020
Look at the provided cgroup path to determine whether systemd is being
used to manage the cgroups. With this, systemd cgroups are being detected
and created appropriately for the sandbox.

Fixes: kata-containers#2818

Signed-off-by: Eric Ernsteernst <[email protected]>
(cherry picked from commit ad5484b)
fidencio pushed a commit to fidencio/kata-runtime that referenced this issue Sep 11, 2020
Look at the provided cgroup path to determine whether systemd is being
used to manage the cgroups. With this, systemd cgroups are being detected
and created appropriately for the sandbox.

Fixes: kata-containers#2818

Signed-off-by: Eric Ernsteernst <[email protected]>
(cherry picked from commit ad5484b)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
None yet
Development

No branches or pull requests

1 participant