Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Increase unit test coverage for virtcontainers #2827

Closed
cmaf opened this issue Jul 13, 2020 · 0 comments · Fixed by #2828
Closed

Increase unit test coverage for virtcontainers #2827

cmaf opened this issue Jul 13, 2020 · 0 comments · Fixed by #2828
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.

Comments

@cmaf
Copy link
Contributor

cmaf commented Jul 13, 2020

There are gaps in unit test coverage for virtcontainers/types/bridges. Expand unit test to include coverage for NewBridge and AddressFormat... functions.
@cmaf cmaf added enhancement Improvement to an existing feature needs-review Needs to be assessed by the team. labels Jul 13, 2020
cmaf pushed a commit to cmaf/runtime that referenced this issue Jul 13, 2020
virtcontainers: Add to bridges unit test
5d14b6d 
Add function that creates new bridges to increase unit test coverage
for virtcontainers/types/bridges.

Fixes kata-containers#2827

Signed-off-by: Chelsea Mafrica <[email protected]>
@cmaf cmaf mentioned this issue Jul 13, 2020
Merged
cmaf pushed a commit to cmaf/runtime that referenced this issue Jul 13, 2020
virtcontainers: Add to bridges unit test
50a4015 
Add function that creates new bridges to increase unit test coverage
for virtcontainers/types/bridges.

Fixes kata-containers#2827

Signed-off-by: Chelsea Mafrica <[email protected]>
cmaf pushed a commit to cmaf/runtime that referenced this issue Jul 15, 2020
virtcontainers: Add to bridges unit test
3f9d700 
Add function that creates new bridges to increase unit test coverage
for virtcontainers/types/bridges. Also adds test for address formats.

Fixes kata-containers#2827

Signed-off-by: Chelsea Mafrica <[email protected]>
cmaf pushed a commit to cmaf/runtime that referenced this issue Jul 15, 2020
virtcontainers: Add to bridges unit test
e71b05b 
Add function that creates new bridges to increase unit test coverage
for virtcontainers/types/bridges. Also adds test for address formats.

Fixes kata-containers#2827

Signed-off-by: Chelsea Mafrica <[email protected]>
egernst pushed a commit to egernst/runtime that referenced this issue Jul 20, 2020
virtcontainers: Add to bridges unit test
079c778 
Add function that creates new bridges to increase unit test coverage
for virtcontainers/types/bridges. Also adds test for address formats.

Fixes kata-containers#2827

Signed-off-by: Chelsea Mafrica <[email protected]>
@jodh-intel jodh-intel mentioned this issue Aug 26, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

virtcontainers: Add to bridges unit test cmaf/runtime
1 participant
@cmaf