Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

clh: Add support to unplug block devices #2832

Closed
likebreath opened this issue Jul 16, 2020 · 0 comments · Fixed by #2833
Closed

clh: Add support to unplug block devices #2832

likebreath opened this issue Jul 16, 2020 · 0 comments · Fixed by #2833
Assignees
@likebreath
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.

Comments

@likebreath
Copy link
Contributor

We are now missing the capability to unplug any devices in kata when using cloud-hypervisor. Enabling the support to unplug block device can be the first step. It is also the root cause of the failure observed from CRI-O CI on kata+clh (kata-containers/tests#2621).
@likebreath likebreath added enhancement Improvement to an existing feature needs-review Needs to be assessed by the team. labels Jul 16, 2020
likebreath added a commit to likebreath/kata-runtime that referenced this issue Jul 16, 2020
@likebreath
clh: Set 'Id' explicitly while hotplugging block device
3d601e0 
To support unplug block device, we need to set the 'Id' explicitly while
hotplugging devices with cloud-hypervisor HTTP API.

Fixes: kata-containers#2832

Signed-off-by: Bo Chen <[email protected]>
likebreath added a commit to likebreath/kata-runtime that referenced this issue Jul 16, 2020
@likebreath
clh: Add support to unplug block devices
3d859b6 
This patch enables kata+clh to unplug block devices, which is required
to pass cri-o integration tests.

Fixes: kata-containers#2832

Signed-off-by: Bo Chen <[email protected]>
@likebreath likebreath mentioned this issue Jul 16, 2020
Merged
@likebreath likebreath self-assigned this Jul 16, 2020
likebreath added a commit to likebreath/kata-runtime that referenced this issue Jul 16, 2020
@likebreath
clh: Add support to unplug block devices
57e68e4 
This patch enables kata+clh to unplug block devices, which is required
to pass cri-o integration tests.

Fixes: kata-containers#2832

Signed-off-by: Bo Chen <[email protected]>
likebreath added a commit to likebreath/kata-runtime that referenced this issue Jul 28, 2020
@likebreath
clh: Set 'Id' explicitly while hotplugging block device
fff7ef9 
To support unplug block device, we need to set the 'Id' explicitly while
hotplugging devices with cloud-hypervisor HTTP API.

Fixes: kata-containers#2832

Signed-off-by: Bo Chen <[email protected]>
likebreath added a commit to likebreath/kata-runtime that referenced this issue Jul 28, 2020
@likebreath
clh: Add support to unplug block devices
bf8a55b 
This patch enables kata+clh to unplug block devices, which is required
to pass cri-o integration tests.

Fixes: kata-containers#2832
Partially fixes: github.com/kata-containers/tests#2546

Signed-off-by: Bo Chen <[email protected]>
likebreath added a commit to likebreath/kata-runtime that referenced this issue Jul 28, 2020
@likebreath
clh: Add support to unplug block devices
c14cd16 
This patch enables kata+clh to unplug block devices, which is required
to pass cri-o integration tests.

Fixes: kata-containers#2832
Partially fixes: github.com/kata-containers/tests#2546

Signed-off-by: Bo Chen <[email protected]>
likebreath added a commit to likebreath/kata-runtime that referenced this issue Aug 13, 2020
@likebreath
clh: Set 'Id' explicitly while hotplugging block device
03fb9c5 
To support unplug block device, we need to set the 'Id' explicitly while
hotplugging devices with cloud-hypervisor HTTP API.

Fixes: kata-containers#2832

Signed-off-by: Bo Chen <[email protected]>
likebreath added a commit to likebreath/kata-runtime that referenced this issue Aug 13, 2020
@likebreath
clh: Add support to unplug block devices
a150e76 
This patch enables kata+clh to unplug block devices, which is required
to pass cri-o integration tests.

Fixes: kata-containers#2832

Signed-off-by: Bo Chen <[email protected]>
likebreath added a commit to likebreath/kata-runtime that referenced this issue Aug 14, 2020
@likebreath
clh: Add support to unplug block devices
44b58e4 
This patch enables kata+clh to unplug block devices, which is required
to pass cri-o integration tests.

Fixes: kata-containers#2832

Signed-off-by: Bo Chen <[email protected]>
@jodh-intel jodh-intel mentioned this issue Aug 26, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@likebreath likebreath

Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

clh: Add support to unplug block devices likebreath/kata-runtime
1 participant
@likebreath