QEMU instance does not exit when VM shuts itself down.

[merwick]

Description of problem

Stopping a Kata VM (e.g. using /proc/sysrq-trigger) from within the VM doesn't cause the QEMU process to exit.

Expected result

echo b > /proc/sysrq-trigger, Kata VM shuts down and QEMU process exits

Actual result

QEMU instance keeps running but VM is now unresponsive having shut down.

---

[merwick]

The Kata architecture does not support rebooting VMs (the lifecycle being start/exec/kill) and if a VM is killed (e.g. using sysrq-trigger), the VM does not exit fully and other layers do not notice the state change.

The QEMU instance needs to be told to exit and not reboot which can be done by passing the --no-reboot command line option when creating the VM.

I am working on a fix for this, please assign issue to me.

[merwick]

@devimc This covers Kata 1.12 but I'm not sure how to deal with Kata 2.0. I ported the changes to the 2.0-dev branch [1] and they pass Travis CI [2] - does it need a separate PR?
[1] merwick/kata-containers@c15ef21
[2] https://travis-ci.org/github/merwick/kata-containers/builds/713350564

[devimc]

@merwick yes please, forwardport this patch,

NOTE: 2.0-dev uses go modules (not dep)

[devimc]

does it need a separate PR?

yes, please

[merwick]

In merwick/kata-containers@5010e3a I made the changes to go.mod, got.sum & vendor/modules.txt (I'm not sure if I should have deleted the old govmm lines (167-168) in go.sum). I'll submit the PR and people can comment there.