Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Expand unit tests for virtcontainers/utils/utils.go #2877

Closed
cmaf opened this issue Aug 6, 2020 · 0 comments · Fixed by #2881
Closed

Expand unit tests for virtcontainers/utils/utils.go #2877

cmaf opened this issue Aug 6, 2020 · 0 comments · Fixed by #2881
Assignees
@cmaf
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.

Comments

@cmaf
Copy link
Contributor

cmaf commented Aug 6, 2020

There is about 55% coverage for virtcontainers/utils/utils.go, they can be expanded by covering additional functions.

Backport for #490
@cmaf cmaf added enhancement Improvement to an existing feature needs-review Needs to be assessed by the team. labels Aug 6, 2020
@cmaf cmaf self-assigned this Aug 6, 2020
@cmaf cmaf mentioned this issue Aug 6, 2020
Closed
cmaf pushed a commit to cmaf/runtime that referenced this issue Aug 7, 2020
virtcontainers: Add to utils unit tests
07f5093 
Expand unit tests for virtcontainers/utils/utils.go to include testing
CleanupFds, CPU calculations, ID string creation, and memory alignment
functions.

Fixes kata-containers#2877

Signed-off-by: Chelsea Mafrica <[email protected]>
@cmaf cmaf mentioned this issue Aug 7, 2020
Merged
cmaf pushed a commit to cmaf/runtime that referenced this issue Aug 7, 2020
virtcontainers: Add to utils unit tests
5debe06 
Expand unit tests for virtcontainers/utils/utils.go to include testing
CleanupFds, CPU calculations, ID string creation, and memory alignment
functions.

Fixes kata-containers#2877

Signed-off-by: Chelsea Mafrica <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cmaf cmaf

Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

virtcontainers: Add to utils unit tests cmaf/runtime
1 participant
@cmaf