Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Add version cli option to shimv2 #2886

Closed
jodh-intel opened this issue Aug 17, 2020 · 0 comments · Fixed by #2887
Closed

Add version cli option to shimv2 #2886

jodh-intel opened this issue Aug 17, 2020 · 0 comments · Fixed by #2887
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.

Comments

@jodh-intel
Copy link
Contributor

All components should support a --version option to allow clear identification of the version of the component being used.

See: kata-containers/kata-containers#307
@jodh-intel jodh-intel added enhancement Improvement to an existing feature needs-review Needs to be assessed by the team. labels Aug 17, 2020
jodh-intel added a commit to jodh-intel/runtimes that referenced this issue Aug 17, 2020
@jodh-intel
shimv2: Add a "--version" cli option
1e74fd3 
All components should support a `--version` option to allow clear
identification of the version of the component being used.

Note that the build changes are required to allow the shim binary to
access the golang code generated by the build
(such as the `version` variable).

Fixes: kata-containers#2886.

Signed-off-by: James O. D. Hunt <[email protected]>
@jodh-intel jodh-intel mentioned this issue Aug 17, 2020
Merged
jodh-intel added a commit to jodh-intel/runtimes that referenced this issue Aug 19, 2020
@jodh-intel
shimv2: Add a "--version" cli option
9bb8e36 
All components should support a `--version` option to allow clear
identification of the version of the component being used.

Note that the build changes are required to allow the shim binary to
access the golang code generated by the build
(such as the `version` variable).

Fixes: kata-containers#2886.

Signed-off-by: James O. D. Hunt <[email protected]>
fidencio pushed a commit to fidencio/kata-runtime that referenced this issue Sep 7, 2020
@jodh-intel @fidencio
shimv2: Add a "--version" cli option
14df242 
All components should support a `--version` option to allow clear
identification of the version of the component being used.

Note that the build changes are required to allow the shim binary to
access the golang code generated by the build
(such as the `version` variable).

Fixes: kata-containers#2886.

Signed-off-by: James O. D. Hunt <[email protected]>
(cherry picked from commit 9bb8e36)
fidencio pushed a commit to fidencio/kata-runtime that referenced this issue Sep 11, 2020
@jodh-intel @fidencio
shimv2: Add a "--version" cli option
bf1d31f 
All components should support a `--version` option to allow clear
identification of the version of the component being used.

Note that the build changes are required to allow the shim binary to
access the golang code generated by the build
(such as the `version` variable).

Fixes: kata-containers#2886.

Signed-off-by: James O. D. Hunt <[email protected]>
(cherry picked from commit 9bb8e36)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

shimv2: Add a "--version" cli option jodh-intel/runtimes
1 participant
@jodh-intel