Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Forget to clean up for s.newStore #2919

Closed
keloyang opened this issue Sep 1, 2020 · 0 comments · Fixed by #2920
Closed

Forget to clean up for s.newStore #2919

keloyang opened this issue Sep 1, 2020 · 0 comments · Fixed by #2920
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.

Comments

@keloyang
Copy link
Contributor

keloyang commented Sep 1, 2020 •
edited
Loading

runtime should call s.newStore.Destroy if globalSandboxList.addSandbox failed at https://github.com/kata-containers/runtime/blob/master/virtcontainers/sandbox.go#L550
@keloyang keloyang added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Sep 1, 2020
@devimc devimc mentioned this issue Sep 1, 2020
Merged
@keloyang keloyang mentioned this issue Sep 9, 2020
Merged
amshinde pushed a commit to amshinde/kata-runtime that referenced this issue Nov 10, 2020
@keloyang @amshinde
runtime: Add s.newStore.Destroy before defer
ebf5f95 
Fixes: kata-containers#2919
Signed-off-by: Shukui Yang <[email protected]>
(cherry picked from commit b44b1ba)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Call s.newStore.Destroy if globalSandboxList.addSandbox failed
1 participant
@keloyang