Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

[backport | master] Fix typo error in virtiofsd test code #2948

Closed
Kvasscn opened this issue Sep 15, 2020 · 0 comments · Fixed by #2949
Closed

[backport | master] Fix typo error in virtiofsd test code #2948

Kvasscn opened this issue Sep 15, 2020 · 0 comments · Fixed by #2949
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.

Comments

@Kvasscn
Copy link
Contributor

Kvasscn commented Sep 15, 2020

Description of problem

"sourcePath" should be "socketDir" in virtiofsd test code https://github.com/kata-containers/runtime/blob/master/virtcontainers/virtiofsd_test.go#L38

same issue with kata-containers/kata-containers#712

Expected result

socketDir, err := ioutil.TempDir("", "")
assert.NoError(err)
defer os.RemoveAll(socketDir)

Actual result

socketDir, err := ioutil.TempDir("", "")
assert.NoError(err)
defer os.RemoveAll(sourcePath)
@Kvasscn Kvasscn added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Sep 15, 2020
@Kvasscn Kvasscn mentioned this issue Sep 15, 2020
Merged
@Kvasscn Kvasscn changed the title [backward port] Fix typo error in virtiofsd test code [backport | master] Fix typo error in virtiofsd test code Sep 15, 2020
chavafg pushed a commit to chavafg/runtime-1 that referenced this issue Oct 16, 2020
@Kvasscn @chavafg
virtiofsd: fix typo in test code
43a6d57 
Fix typo in virtiofsd_test.go

Fixes: kata-containers#2948

Signed-off-by: zhanghj <[email protected]>
(cherry picked from commit 1e91677)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

virtiofsd: fix typo in test code
1 participant
@Kvasscn