Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

If no CPU time restrictions are enforced, we should size VM according to cpusets.cpus #2971

Closed
egernst opened this issue Sep 18, 2020 · 0 comments
Closed

If no CPU time restrictions are enforced, we should size VM according to cpusets.cpus #2971

egernst opened this issue Sep 18, 2020 · 0 comments
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.

Comments

@egernst
Copy link
Member

egernst commented Sep 18, 2020

If you run a container with Kata that is constrained only by cpusets, but not cpu.cfs_quota, it will not add any additional CPUs. If cpu.cfs_quota is not specified for any of the containers, we should size the VM based on cpuset.cpus, if specified.
@egernst egernst added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Sep 18, 2020
egernst added a commit to egernst/runtime that referenced this issue Sep 18, 2020
@egernst
sandbox: consider cpusets if quota is not enforced
04c96b4 
If quota is not being enforced on any containers but CPUsets are
specified, take the number of CPU sets into account when sizing the
virtual machine.

Fixes: kata-containers#2971

Signed-off-by: Eric Ernst <[email protected]>
egernst added a commit to egernst/runtime that referenced this issue Sep 21, 2020
@egernst
sandbox: consider cpusets if quota is not enforced
479fd70 
If quota is not being enforced on any containers but CPUsets are
specified, take the number of CPU sets into account when sizing the
virtual machine.

Fixes: kata-containers#2971

Signed-off-by: Eric Ernst <[email protected]>
egernst added a commit to egernst/runtime that referenced this issue Sep 21, 2020
@egernst
sandbox: consider cpusets if quota is not enforced
a7b019d 
If quota is not being enforced on any containers but CPUsets are
specified, take the number of CPU sets into account when sizing the
virtual machine.

Fixes: kata-containers#2971

Signed-off-by: Eric Ernst <[email protected]>
egernst added a commit to egernst/runtime that referenced this issue Sep 21, 2020
@egernst
sandbox: consider cpusets if quota is not enforced
7788cb7 
If quota is not being enforced on any containers but CPUsets are
specified, take the number of CPU sets into account when sizing the
virtual machine.

Fixes: kata-containers#2971

Signed-off-by: Eric Ernst <[email protected]>
egernst added a commit to egernst/runtime that referenced this issue Sep 21, 2020
@egernst
sandbox: consider cpusets if quota is not enforced
f49d6fc 
If quota is not being enforced on any containers but CPUsets are
specified, take the number of CPU sets into account when sizing the
virtual machine.

Fixes: kata-containers#2971

Signed-off-by: Eric Ernst <[email protected]>
@devimc devimc closed this as completed in 8ef2946 Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@egernst