This repository has been archived by the owner on May 12, 2021. It is now read-only.
Remove all CNI code #567
Comments
amshinde
added a commit
to amshinde/kata-runtime
that referenced
this issue
Aug 9, 2018
We dont really call CNI from Kata, this is done by the CRI layer. All of the CNI code is unused. Fixes kata-containers#567 Signed-off-by: Archana Shinde <[email protected]>
|
This makes me think, we should open an issue to track if there's any other code part like this one. Things that we actually don't use at all ? |
|
@sboeuf Sure, please open one. Are you aware of any other unused code at the moment? |
|
@amshinde nothing comes to mind, but I just want to make sure we reduce the codebase if possible. |
amshinde
added a commit
to amshinde/kata-runtime
that referenced
this issue
Aug 10, 2018
We dont really call CNI from Kata, this is done by the CRI layer. All of the CNI code is unused. Fixes kata-containers#567 Signed-off-by: Archana Shinde <[email protected]>
|
In theory maybe we can partly identify them using code coverage from the test suite ;-) OK, we know there are some parts we probably still want that the tests don't (currently) cover - but maybe that will help us form a list of missing test areas as well. |
amshinde
added a commit
to amshinde/kata-runtime
that referenced
this issue
Aug 14, 2018
We dont really call CNI from Kata, this is done by the CRI layer. All of the CNI code is unused. Fixes kata-containers#567 Signed-off-by: Archana Shinde <[email protected]>
lifupan
pushed a commit
to hyperhq/kata-runtime
that referenced
this issue
Sep 17, 2018
We dont really call CNI from Kata, this is done by the CRI layer. All of the CNI code is unused. Fixes kata-containers#567 Signed-off-by: Archana Shinde <[email protected]>
zklei
pushed a commit
to zklei/runtime
that referenced
this issue
Jun 13, 2019
…esUnitTest grpc: add unit test for onlineResources function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We dont really call CNI from Kata runtime. Remove all of this code as it is not really called. It is also leads to confusion whether CNI is being called by the kata-runitme.
The text was updated successfully, but these errors were encountered: