Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

virtcontainers: storage: separate interface from implementations #633

Closed
sboeuf opened this issue Aug 23, 2018 · 0 comments
Closed

virtcontainers: storage: separate interface from implementations #633

sboeuf opened this issue Aug 23, 2018 · 0 comments
Assignees

Comments

@sboeuf
Copy link

sboeuf commented Aug 23, 2018

Both filesystem and noopStorageResource implementations of the resourceStorage interface should be separate from the interface declaration.

sboeuf pushed a commit to sboeuf/runtime-1 that referenced this issue Aug 23, 2018
The storage implementation of filesystem was in the same file where
the resource storage interface was declared. It's more proper to
separate implementations and interface into different files.

Fixes kata-containers#633

Signed-off-by: Sebastien Boeuf <[email protected]>
@egernst egernst added the review label Aug 23, 2018
@egernst egernst removed the review label Aug 24, 2018
lifupan pushed a commit to hyperhq/kata-runtime that referenced this issue Sep 17, 2018
The storage implementation of filesystem was in the same file where
the resource storage interface was declared. It's more proper to
separate implementations and interface into different files.

Fixes kata-containers#633

Signed-off-by: Sebastien Boeuf <[email protected]>
egernst pushed a commit to egernst/runtime that referenced this issue Feb 9, 2021
Install the golang version specified in the versions.yaml
before installing the agent

fixes kata-containers#633

Signed-off-by: Julio Montes <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants