Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

start proxy in vm factory #683

Closed
bergwolf opened this issue Aug 31, 2018 · 2 comments
Closed

start proxy in vm factory #683

bergwolf opened this issue Aug 31, 2018 · 2 comments

Comments

@bergwolf
Copy link
Member

Right now proxy is always started after we assign the guest vm to a sandbox. But then we will have to wait again for the proxy to start up. We can move the creation of proxy to vm factory so that new vms are created with configured proxy type, and then wait for both proxy and vm/agent in parallel. This will save about 300ms startup time for vm factory.

bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Aug 31, 2018
The PR moves ahead the start of proxy process for vm factory so that
it waits for both vm and proxy to be up at the same time. This saves
about 300ms for new container creation in my local test machine.

Fixes: kata-containers#683

Signed-off-by: Peng Tao <[email protected]>
@jodh-intel
Copy link
Contributor

And that would presumably be a NOP if vsock was enabled?

bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Aug 31, 2018
The PR moves ahead the start of proxy process for vm factory so that
it waits for both vm and proxy to be up at the same time. This saves
about 300ms for new container creation in my local test machine.

Fixes: kata-containers#683

Signed-off-by: Peng Tao <[email protected]>
@bergwolf
Copy link
Member Author

@jodh-intel Yes. It does not matter what proxy type is configured. I just called proxy.start() there.

bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Sep 4, 2018
The PR moves ahead the start of proxy process for vm factory so that
it waits for both vm and proxy to be up at the same time. This saves
about 300ms for new container creation in my local test machine.

Fixes: kata-containers#683

Signed-off-by: Peng Tao <[email protected]>
bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Sep 4, 2018
The PR moves ahead the start of proxy process for vm factory so that
it waits for both vm and proxy to be up at the same time. This saves
about 300ms for new container creation in my local test machine.

Fixes: kata-containers#683

Signed-off-by: Peng Tao <[email protected]>
bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Sep 5, 2018
The PR moves ahead the start of proxy process for vm factory so that
it waits for both vm and proxy to be up at the same time. This saves
about 300ms for new container creation in my local test machine.

Fixes: kata-containers#683

Signed-off-by: Peng Tao <[email protected]>
bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Sep 6, 2018
The PR moves ahead the start of proxy process for vm factory so that
it waits for both vm and proxy to be up at the same time. This saves
about 300ms for new container creation in my local test machine.

Fixes: kata-containers#683

Signed-off-by: Peng Tao <[email protected]>
bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Sep 7, 2018
The PR moves ahead the start of proxy process for vm factory so that
it waits for both vm and proxy to be up at the same time. This saves
about 300ms for new container creation in my local test machine.

Fixes: kata-containers#683

Signed-off-by: Peng Tao <[email protected]>
bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Sep 8, 2018
The PR moves ahead the start of proxy process for vm factory so that
it waits for both vm and proxy to be up at the same time. This saves
about 300ms for new container creation in my local test machine.

Fixes: kata-containers#683

Signed-off-by: Peng Tao <[email protected]>
bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Sep 11, 2018
The PR moves ahead the start of proxy process for vm factory so that
it waits for both vm and proxy to be up at the same time. This saves
about 300ms for new container creation in my local test machine.

Depends-on: github.com/kata-containers#710
Fixes: kata-containers#683

Signed-off-by: Peng Tao <[email protected]>
bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Sep 11, 2018
The PR moves ahead the start of proxy process for vm factory so that
it waits for both vm and proxy to be up at the same time. This saves
about 300ms for new container creation in my local test machine.

Fixes: kata-containers#683

Signed-off-by: Peng Tao <[email protected]>
bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Sep 12, 2018
The PR moves ahead the start of proxy process for vm factory so that
it waits for both vm and proxy to be up at the same time. This saves
about 300ms for new container creation in my local test machine.

Fixes: kata-containers#683

Signed-off-by: Peng Tao <[email protected]>
egernst pushed a commit to egernst/runtime that referenced this issue Feb 9, 2021
This adds an option to the agent to control the hotplug timeout of block devices.
Retains the previous behaviour of defaulting to 3 seconds if not specified.
Can be increased when block device hot plugging is taking longer than expected.

Fixes kata-containers#683

Signed-off-by: Alex Price <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants