Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Network:the network added via hotplug is not available when machine=q35 #861

Closed
miaoyq opened this issue Oct 26, 2018 · 7 comments
Closed

Comments

@miaoyq
Copy link

miaoyq commented Oct 26, 2018

Description of problem

I set machine_type = q35, and created a kata container.
When I attached a veth to the container, found the veth was unavailable,

@sboeuf


(replace this text with the output of the kata-collect-data.sh script, after
you have reviewed its content to ensure it does not contain any private
information).

@grahamwhaley
Copy link
Contributor

grahamwhaley commented Oct 26, 2018

I believe there are different PCI(e) hotplug features between q35 and 'pc' - iirc, q35 maybe PCI, not PCIe, and thus not have hotplug. /cc @devimc who did the original looking into this iirc.

@sboeuf
Copy link

sboeuf commented Oct 26, 2018

@miaoyq you should be able (relying on latest agent and latest runtime) to hotplug some additional interfaces when using q35. But in case of q35, the root bus is not directly hotpluggable, which means that if you use hotplug_vfio_on_root_bus = true from configuration.toml, this won't work.

@devimc
Copy link

devimc commented Oct 31, 2018

@miaoyq also please update kata kernel, SHPC must be enabled

@miaoyq
Copy link
Author

miaoyq commented Nov 1, 2018

@sboeuf Sorry for my delay, you're right 👍
I set hotplug_vfio_on_root_bus = true and machine_type = q35, it works well. Thanks.

@devimc Yes, SHPC have been enabled. Thanks for reminder. :-)

@miaoyq
Copy link
Author

miaoyq commented Nov 1, 2018

I will close this issue.

@miaoyq miaoyq closed this as completed Nov 1, 2018
@grahamwhaley
Copy link
Contributor

Glad this is now working - it makes me wonder though, are we missing some documentation here, or should it be in a better/clearer/easier-to-find place etc.?

@miaoyq
Copy link
Author

miaoyq commented Nov 1, 2018

@grahamwhaley There are instructions actually in configuration.toml. It would be better to have an explanation in the document I think. :-)

egernst pushed a commit to egernst/runtime that referenced this issue Feb 9, 2021
"make proto" will fail on arm64 using docker 18.06. This bug will be
gone if using docker 19.03. so upgrade docker before "make proto"
for arm64.

Depends-on: github.com/kata-containers#3057
Fixes: kata-containers#861
Signed-off-by: Jianyong Wu <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants