This repository has been archived by the owner on May 12, 2021. It is now read-only.

sandbox: Extend sandbox API #903

Closed

sboeuf opened this issue Nov 12, 2018 · 0 comments

sboeuf commented Nov 12, 2018

In order to support use cases such as kata-containerd-shim-v2, where we have a long running process holding the Sandbox pointer, there is no reason to call into the stateless functions, as they would recreate a new Sandbox pointer and the corresponding ones for containers.

Instead, we should allow such case to use the sandbox API directly, avoiding to waste time in re-initialization and duplication.

The text was updated successfully, but these errors were encountered:

sboeuf pushed a commit to sboeuf/runtime-1 that referenced this issue


          sandbox: Export Start() to the API level

6c3e266

In order to support use cases such as containerd-shim-v2 where we
would have a long running process holding the sandbox pointer, there
would be no reason to call into the stateless function StartSandbox(),
which would recreate a new sandbox pointer and the corresponding ones
for containers.

Fixes kata-containers#903

Signed-off-by: Sebastien Boeuf <[email protected]>

sboeuf pushed a commit to sboeuf/runtime-1 that referenced this issue


          sandbox: Export Stop() to the API level

109e12a

In order to support use cases such as containerd-shim-v2 where we
would have a long running process holding the sandbox pointer, there
would be no reason to call into the stateless function StopSandbox(),
which would recreate a new sandbox pointer and the corresponding ones
for containers.

Fixes kata-containers#903

Signed-off-by: Sebastien Boeuf <[email protected]>

sboeuf pushed a commit to sboeuf/runtime-1 that referenced this issue


          sandbox: Create and export StopContainer() to the API level

In order to support use cases such as containerd-shim-v2 where we
would have a long running process holding the sandbox pointer, there
would be no reason to call into the stateless function StopContainer(),
which would recreate a new sandbox pointer and the corresponding ones
for containers.

Fixes kata-containers#903

Signed-off-by: Sebastien Boeuf <[email protected]>

sboeuf pushed a commit to sboeuf/runtime-1 that referenced this issue


          sandbox: Create and export KillContainer() to the API level

3add296

In order to support use cases such as containerd-shim-v2 where we
would have a long running process holding the sandbox pointer, there
would be no reason to call into the stateless function KillContainer(),
which would recreate a new sandbox pointer and the corresponding ones
for containers.

Fixes kata-containers#903

Signed-off-by: Sebastien Boeuf <[email protected]>

sboeuf pushed a commit to sboeuf/runtime-1 that referenced this issue


          sandbox: Create and export ProcessListContainer() to the API level

b298ec4

In order to support use cases such as containerd-shim-v2 where
we would have a long running process holding the sandbox pointer,
there would be no reason to call into the stateless function
ProcessListContainer(), which would recreate a new sandbox pointer
and the corresponding ones for containers.

Fixes kata-containers#903

Signed-off-by: Sebastien Boeuf <[email protected]>

sboeuf pushed a commit to sboeuf/runtime-1 that referenced this issue


          sandbox: Create and export Pause/ResumeContainer() to the API level

In order to support use cases such as containerd-shim-v2 where
we would have a long running process holding the sandbox pointer,
there would be no reason to call into the stateless functions
PauseContainer() and ResumeContainer(), which would recreate a
new sandbox pointer and the corresponding ones for containers.

Fixes kata-containers#903

Signed-off-by: Sebastien Boeuf <[email protected]>

sboeuf mentioned this issue

sandbox: Extend sandbox API #904

Merged

sboeuf closed this as completed in #904

zklei pushed a commit to zklei/runtime that referenced this issue


          sandbox: Export Start() to the API level

f54d4f3

In order to support use cases such as containerd-shim-v2 where we
would have a long running process holding the sandbox pointer, there
would be no reason to call into the stateless function StartSandbox(),
which would recreate a new sandbox pointer and the corresponding ones
for containers.

Fixes kata-containers#903

Signed-off-by: Sebastien Boeuf <[email protected]>

zklei pushed a commit to zklei/runtime that referenced this issue


          sandbox: Export Stop() to the API level

71b42bc

In order to support use cases such as containerd-shim-v2 where we
would have a long running process holding the sandbox pointer, there
would be no reason to call into the stateless function StopSandbox(),
which would recreate a new sandbox pointer and the corresponding ones
for containers.

Fixes kata-containers#903

Signed-off-by: Sebastien Boeuf <[email protected]>

zklei pushed a commit to zklei/runtime that referenced this issue


          sandbox: Create and export StopContainer() to the API level

2080e6f

In order to support use cases such as containerd-shim-v2 where we
would have a long running process holding the sandbox pointer, there
would be no reason to call into the stateless function StopContainer(),
which would recreate a new sandbox pointer and the corresponding ones
for containers.

Fixes kata-containers#903

Signed-off-by: Sebastien Boeuf <[email protected]>

zklei pushed a commit to zklei/runtime that referenced this issue


          sandbox: Create and export KillContainer() to the API level

985faa1

In order to support use cases such as containerd-shim-v2 where we
would have a long running process holding the sandbox pointer, there
would be no reason to call into the stateless function KillContainer(),
which would recreate a new sandbox pointer and the corresponding ones
for containers.

Fixes kata-containers#903

Signed-off-by: Sebastien Boeuf <[email protected]>

zklei pushed a commit to zklei/runtime that referenced this issue


          sandbox: Create and export ProcessListContainer() to the API level

2e6a09e

In order to support use cases such as containerd-shim-v2 where
we would have a long running process holding the sandbox pointer,
there would be no reason to call into the stateless function
ProcessListContainer(), which would recreate a new sandbox pointer
and the corresponding ones for containers.

Fixes kata-containers#903

Signed-off-by: Sebastien Boeuf <[email protected]>

zklei pushed a commit to zklei/runtime that referenced this issue


          sandbox: Create and export Pause/ResumeContainer() to the API level

48407c2

In order to support use cases such as containerd-shim-v2 where
we would have a long running process holding the sandbox pointer,
there would be no reason to call into the stateless functions
PauseContainer() and ResumeContainer(), which would recreate a
new sandbox pointer and the corresponding ones for containers.

Fixes kata-containers#903

Signed-off-by: Sebastien Boeuf <[email protected]>

zklei pushed a commit to zklei/runtime that referenced this issue


          sandbox: Export Start() to the API level

e2e4cb0

In order to support use cases such as containerd-shim-v2 where we
would have a long running process holding the sandbox pointer, there
would be no reason to call into the stateless function StartSandbox(),
which would recreate a new sandbox pointer and the corresponding ones
for containers.

Fixes kata-containers#903

Signed-off-by: Sebastien Boeuf <[email protected]>

zklei pushed a commit to zklei/runtime that referenced this issue


          sandbox: Export Stop() to the API level

96a9681

In order to support use cases such as containerd-shim-v2 where we
would have a long running process holding the sandbox pointer, there
would be no reason to call into the stateless function StopSandbox(),
which would recreate a new sandbox pointer and the corresponding ones
for containers.

Fixes kata-containers#903

Signed-off-by: Sebastien Boeuf <[email protected]>

zklei pushed a commit to zklei/runtime that referenced this issue


          sandbox: Create and export StopContainer() to the API level

729810c

In order to support use cases such as containerd-shim-v2 where we
would have a long running process holding the sandbox pointer, there
would be no reason to call into the stateless function StopContainer(),
which would recreate a new sandbox pointer and the corresponding ones
for containers.

Fixes kata-containers#903

Signed-off-by: Sebastien Boeuf <[email protected]>

zklei pushed a commit to zklei/runtime that referenced this issue


          sandbox: Create and export KillContainer() to the API level

013a21c

In order to support use cases such as containerd-shim-v2 where we
would have a long running process holding the sandbox pointer, there
would be no reason to call into the stateless function KillContainer(),
which would recreate a new sandbox pointer and the corresponding ones
for containers.

Fixes kata-containers#903

Signed-off-by: Sebastien Boeuf <[email protected]>

zklei pushed a commit to zklei/runtime that referenced this issue


          sandbox: Create and export ProcessListContainer() to the API level

238c506

In order to support use cases such as containerd-shim-v2 where
we would have a long running process holding the sandbox pointer,
there would be no reason to call into the stateless function
ProcessListContainer(), which would recreate a new sandbox pointer
and the corresponding ones for containers.

Fixes kata-containers#903

Signed-off-by: Sebastien Boeuf <[email protected]>

zklei pushed a commit to zklei/runtime that referenced this issue


          sandbox: Create and export Pause/ResumeContainer() to the API level

c2c3588

In order to support use cases such as containerd-shim-v2 where
we would have a long running process holding the sandbox pointer,
there would be no reason to call into the stateless functions
PauseContainer() and ResumeContainer(), which would recreate a
new sandbox pointer and the corresponding ones for containers.

Fixes kata-containers#903

Signed-off-by: Sebastien Boeuf <[email protected]>

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.