Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

s390x: change pci bridge type #1142

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Conversation

alicefr
Copy link

@alicefr alicefr commented Jan 17, 2019

Fixes: #1141

Signed-off-by: Alice Frosi [email protected]

Copy link
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Might be nice to have at least one line of commit message body - in fact our CI may reject when it sees that :-) Maybe a ref to the change that made this happen would be nice.

@sameo
Copy link

sameo commented Jan 17, 2019

LGTM

Approved with PullApprove

@sameo
Copy link

sameo commented Jan 17, 2019

@alicefr Sorry about that one. Are there any plans to include s390 as part of our CI?

@grahamwhaley
Copy link
Contributor

In progress right now @sameo - we have access to a node, and are setting it up as a jenkins slave.

Change type name for PCIBridge

Fixes: kata-containers#1141

Signed-off-by: Alice Frosi <[email protected]>
@alicefr
Copy link
Author

alicefr commented Jan 17, 2019

@grahamwhaley sorry I always forget 😅

Copy link

@devimc devimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@caoruidong
Copy link
Member

/test

@jodh-intel
Copy link
Contributor

jodh-intel commented Jan 22, 2019

lgtm

Approved with PullApprove

@jodh-intel jodh-intel merged commit c271d1c into kata-containers:master Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants