This repository has been archived by the owner on May 12, 2021. It is now read-only.
rootless: Fix cgroup creation logic for rootless #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not want to create cgroups in case of rootless. Fix the logic to implement this. Fixes kata-containers#2177 Signed-off-by: Archana Shinde <[email protected]>
Closed
bergwolf
approved these changes
Nov 11, 2019
|
/test |
Codecov Report
@@ Coverage Diff @@
## master #2178 +/- ##
=========================================
Coverage ? 50.95%
=========================================
Files ? 110
Lines ? 15209
Branches ? 0
=========================================
Hits ? 7750
Misses ? 6505
Partials ? 954 |
devimc
approved these changes
Nov 11, 2019
egernst
approved these changes
Nov 11, 2019
|
@amshinde can you please send this fix over to stable-1.9 as well? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not want to create cgroups in case of rootless.
Fix the logic to implement this.
Fixes #2177
Signed-off-by: Archana Shinde [email protected]