This repository has been archived by the owner on May 12, 2021. It is now read-only.
fc: config: vhost-net not supported #2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhost-net backend is not supported by the Firecracker VMM. It doesn't make sense to have this in the configuration, and we should explicitly disable it. Fixes: kata-containers#2192 Signed-off-by: Eric Ernst <[email protected]>
|
/test |
Codecov Report
@@ Coverage Diff @@
## master #2194 +/- ##
==========================================
+ Coverage 50.98% 51.65% +0.66%
==========================================
Files 110 110
Lines 15224 15574 +350
==========================================
+ Hits 7762 8044 +282
- Misses 6506 6531 +25
- Partials 956 999 +43 |
amshinde
approved these changes
Nov 13, 2019
jodh-intel
approved these changes
Nov 14, 2019
GabyCT
approved these changes
Nov 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vhost-net backend is not supported by the Firecracker VMM. It doesn't
make sense to have this in the configuration, and we should explicitly
disable it.
Fixes: #2192
Signed-off-by: Eric Ernst [email protected]