This repository has been archived by the owner on May 12, 2021. It is now read-only.
Remove nemu #2196
Merged
Remove nemu #2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
|
/test |
amshinde
approved these changes
Nov 13, 2019
Codecov Report
@@ Coverage Diff @@
## master #2196 +/- ##
=========================================
Coverage ? 51.25%
=========================================
Files ? 110
Lines ? 15114
Branches ? 0
=========================================
Hits ? 7747
Misses ? 6410
Partials ? 957 |
|
/test ubuntu-18-04 |
sameo
approved these changes
Nov 14, 2019
jodh-intel
approved these changes
Nov 14, 2019
There was a problem hiding this comment.
Just for clarity, no children, kittens, 🐈s, 🐄s, 🦄s, 🐫s or 🪲s were hurt in the preperation of this PR folks!
lgtm
We do need to think about the user impact of this change though. It needs to be mentioned (prominently) in the next releases release notes as a minimum as it's a breaking change.
chavafg
approved these changes
Nov 14, 2019
GabyCT
approved these changes
Nov 14, 2019
NEMU deprecation was announced in 1.8 of Kata. Removing from tree. Thanks for all the fish! Fixes: kata-containers#2195 Signed-off-by: Eric Ernst <[email protected]>
|
/test |
|
Restarted Debian CI which failed with the following error: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation was announced in 1.8, and we no longer support the NEMU VMM, as it is not actively maintained and the benefits of NEMU are now mostly realized by QEMU, Firecracker and Cloud Hypervisor VMMs.
This PR removes it from the runtime.