This repository has been archived by the owner on May 12, 2021. It is now read-only.
qemu-configs: update disable_vhost_net description #2197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egernst
force-pushed
the
disable-vhost-comment
branch
from
b28e30b to
0c482b2
Compare
egernst
requested review from
jodh-intel,
bergwolf,
gnawux,
amshinde and
sboeuf
|
/test |
Updated to better clarify this configuration option. Currently in QEMU pre 1.9 release of Kata, vhost-net is used for the virtio-net backend. This results in efficient network I/O performance, but does rely on the backend running in ring0 (host kernel). Update comment to clarify this trade-off for end-users. Fixes: kata-containers#2198 Signed-off-by: Eric Ernst <[email protected]>
sboeuf
approved these changes
Nov 13, 2019
amshinde
approved these changes
Nov 13, 2019
Codecov Report
@@ Coverage Diff @@
## master #2197 +/- ##
=========================================
Coverage ? 51.18%
=========================================
Files ? 110
Lines ? 15082
Branches ? 0
=========================================
Hits ? 7720
Misses ? 6406
Partials ? 956 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should consider disable vhost-net for QEMU configuration in 1.10, though I'd like to get feedback from users/community here.
In the meantime, let's clarify what this configuration does.
Fixes: ###
Signed-off-by: Eric Ernst [email protected]