vc: Remove extra call to Kill

[tedyu]

This PR addresses this comment:
https://github.com/kata-containers/runtime/pull/2164/files#r346776205

/cc @jodh-intel

[tedyu]

ERROR: Commit 94b931cee4ec571e4bccc42b5403add73558ebbc: Failed to find subsystem in subject: "Remove extra call to Kill"

I looked at recent commits but didn't find pattern of embedding subsystem in the subject.

[tedyu]

/assign @jodh-intel

[grahamwhaley]

@tedyu - the 'subsystem' CI failure is telling you your commit subject line does not meet the format documented at:
https://github.com/kata-containers/community/blob/master/CONTRIBUTING.md#general-format

[grahamwhaley]

Looking at the patch, virtcontainers is probably the correct/appropriate subsystem, so renaming the commit subject to say:

vc: remove extra call to kill

would be the right thing. You can do that with a 'git commit --amend' and 'git push -f' for instance.

[egernst]

Thanks for the fix.

[egernst]

@tedyu you need a body on the commit. Further, you’ll want a reference to a GitHub issue which this PR addresses and a signed-off-by. Sorry for the extra hoops, and appreciate your help.

[egernst]

To help: I opened issue for you: #2207

[tedyu]

@egernst
I have added the body for the commit.

[tedyu]

Does enkins-ci-ubuntu-18-04 normally take more than 2 hours to complete ?

[grahamwhaley]

/test
@tedyu - it needs triggering first ;-)

[tedyu]

For Power8-ubuntu:

ERROR: kata-log-parser: missing pid: {Count:0 TimeDelta:0 Filename:/home/jenkins/workspace/kata-containers-runtime-Power8-ubuntu-18-04-PR-initrd/go/src/github.com/kata-containers/tests/kata-runtime.log Line:47 Time:2019-11-17 21:31:04.495442708 -0500 EST Pid:0 Level:debug Msg:converting /run/docker/containerd/daemon/io.containerd.runtime.v1.linux/moby/17469350cf17a841e3f4e101cb9687f798531f1c8d336871038eb9d10bb34b30/config.json Source:virtcontainers Name: Container: Sandbox: Data:map[subsystem:compatoci]}

I don't think the above was caused by my PR.

[tedyu]

/retest jenkins-ci-Power8-ubuntu-18-04-PR-initrd

[tedyu]

Looks like I don't have permission to re-trigger test.

[codecov]

Codecov Report

Merging #2204 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #2204   +/-   ##
=======================================
  Coverage   49.35%   49.35%           
=======================================
  Files         111      111           
  Lines       15791    15791           
=======================================
  Hits         7794     7794           
  Misses       7032     7032           
  Partials      965      965

[grahamwhaley]

@tedyu - possibly not - you have to be a member of the kata org and iirc the correct team, to do that...
Also, if you follow
https://github.com/kata-containers/ci#controlling-the-ci over to https://github.com/kata-containers/community/wiki/Controlling-the-CI you can see the list of commands that should work...

Let's try:

/test-power

[grahamwhaley]

also, if you need to locate who might be responsible for which bit of the project or infra, there is a table over at https://github.com/kata-containers/community/wiki/Areas-of-interest#resource-owners to help guide (in case we need to find the Power CI owners etc.)

[tedyu]

/test-power

[tedyu]

@grahamwhaley
I cannot trigger test rerun.

[tedyu]

@grahamwhaley @egernst
When you have a chance, can you trigger another test run ?

thanks

[egernst]

/test

[jodh-intel]

Thanks @tedyu - there are other instances of this "double kill". I was about to say you could update this PR for those, but it got merged underneath me :) Therefore, if you are interested, feel free to raise a follow-on PR to update virtcontainers/acrn.go and virtcontainers/fc.go.

Regarding the coverage stats - we have never found a reliable service unfortunately. It's on the "TODO" list but if anyone has spare cycles, feel free to dig in! 😄