This repository has been archived by the owner on May 12, 2021. It is now read-only.
Respect containerd's debug config #2208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @choury - thanks for the PR. Looks sane to me, but I will let others fully review.... |
choury
force-pushed
the
patch-1
branch
5 times, most recently
from
1969419 to
d30f210
Compare
lifupan
reviewed
Nov 19, 2019
There are too many logs from kata shim in containerd's log. Fixes kata-containers#2209 Signed-off-by: choury <[email protected]>
lifupan
approved these changes
Nov 21, 2019
|
/test |
Codecov Report
@@ Coverage Diff @@
## master #2208 +/- ##
=========================================
Coverage ? 49.04%
=========================================
Files ? 111
Lines ? 16063
Branches ? 0
=========================================
Hits ? 7878
Misses ? 7211
Partials ? 974 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, There are too many logs from kata shim in containerd's log. We should handle it.
Fix #2209