Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

virtcontainers: Disable cpuset and cpumem #222

Merged
merged 1 commit into from
Apr 17, 2018

Conversation

chavafg
Copy link
Contributor

@chavafg chavafg commented Apr 16, 2018

Disable cpuset and cpumem constraints as this is not properly
supported yet.

If we add "cpuset_cpus" and "cpuset_mems" to the container.json,
kata-runtime failed to start, so we need to disable them.

Fixes: #221.

Signed-off-by: Salvador Fuentes [email protected]

@chavafg chavafg requested a review from sboeuf April 16, 2018 21:34
@chavafg chavafg added the review label Apr 16, 2018
@chavafg chavafg force-pushed the topic/cpu-resources branch from d70ab38 to 32e8d60 Compare April 16, 2018 21:41
@chavafg chavafg changed the title virtcontainers: kata_agent: set CPU resource to nil virtcontainers: Disable cpu constraints Apr 16, 2018
Disable cpuset and cpumem constraints as this is not properly
supported yet.

If we add "cpuset_cpus" and "cpuset_mems" to the container.json,
kata-runtime failed to start, so we need to disable them.

Fixes: kata-containers#221.

Signed-off-by: Salvador Fuentes <[email protected]>
@chavafg chavafg force-pushed the topic/cpu-resources branch from 32e8d60 to 5dc0432 Compare April 16, 2018 21:52
@chavafg chavafg changed the title virtcontainers: Disable cpu constraints virtcontainers: Disable cpuset and cpumem Apr 16, 2018
@chavafg chavafg force-pushed the topic/cpu-resources branch from 5dc0432 to a608ff0 Compare April 16, 2018 21:55
@codecov
Copy link

codecov bot commented Apr 16, 2018

Codecov Report

Merging #222 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
+ Coverage   65.33%   65.33%   +<.01%     
==========================================
  Files          73       73              
  Lines        7707     7709       +2     
==========================================
+ Hits         5035     5037       +2     
  Misses       2128     2128              
  Partials      544      544
Impacted Files Coverage Δ
virtcontainers/kata_agent.go 33.19% <100%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8088a62...a608ff0. Read the comment docs.

@sboeuf
Copy link

sboeuf commented Apr 16, 2018

@bergwolf PTAL !

@bergwolf
Copy link
Member

bergwolf commented Apr 17, 2018

lgtm

Approved with PullApprove

@bergwolf bergwolf merged commit be6ef03 into kata-containers:master Apr 17, 2018
@amshinde amshinde removed the review label Apr 17, 2018
@chavafg chavafg deleted the topic/cpu-resources branch July 12, 2018 14:12
zklei pushed a commit to zklei/runtime that referenced this pull request Jun 13, 2019
grpc :Add the StatsContainer api for `events cli`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants