Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

config: Disable jailer by default for firecracker #2229

Merged
merged 1 commit into from
Nov 20, 2019
Merged

config: Disable jailer by default for firecracker #2229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cli/config/configuration-fc.toml.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ path = "@FCPATH@"
# If the jailer path is not set kata will launch firecracker
# without a jail. If the jailer is set firecracker will be
# launched in a jailed enviornment created by the jailer
jailer_path = "@FCJAILERPATH@"
# This is disabled by default as additional setup is required
# for this feature today.
#jailer_path = "@FCJAILERPATH@"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we update the comment to note why it is disabled by default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grahamwhaley I have added a comment. @egernst Let me know if that looks ok to you.

kernel = "@KERNELPATH_FC@"
image = "@IMAGEPATH@"

Expand Down