This repository has been archived by the owner on May 12, 2021. It is now read-only.
vc: Persist file handle may leak in FS#FromDisk #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2233 Signed-off-by: Ted Yu <[email protected]>
|
@amshinde @grahamwhaley |
grahamwhaley
approved these changes
Nov 21, 2019
There was a problem hiding this comment.
lgtm
OOI @tedyu - are you finding all these races etc. by visual inspection, debugging, or some analysis tools? :-)
lifupan
approved these changes
Nov 21, 2019
|
/test-ubuntu |
|
@grahamwhaley |
Codecov Report
@@ Coverage Diff @@
## master #2234 +/- ##
=========================================
Coverage ? 48.98%
=========================================
Files ? 111
Lines ? 16027
Branches ? 0
=========================================
Hits ? 7851
Misses ? 7203
Partials ? 973 |
|
@grahamwhaley @lifupan |
devimc
approved these changes
Nov 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2233
Signed-off-by: Ted Yu [email protected]