This repository has been archived by the owner on May 12, 2021. It is now read-only.
runv: modify GOPATH to build #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@jodh-intel Could you please review? |
|
This doesn't work for me: |
|
How about making a temp dir under runtime root dir and using a soft link? a quick example: It needs a little bit more modifications to make it work, only for showing my ideas. |
|
@jodh-intel did you sync submodule after pulling the pr locally? What is the output of |
So that we can use runv repo as git submodule without splitting it. Signed-off-by: Peng Tao <[email protected]>
|
@WeiZhang555 thanks for the suggestion. PR updated. |
|
LGTM |
|
Hi @bergwolf - sorry, yes, my repo was stale. lgtm. |
jodh-intel
pushed a commit
to jodh-intel/runtimes
that referenced
this pull request
Mar 15, 2018
docs: Replace Clear with Kata.
mcastelino
added a commit
to mcastelino/runtime-1
that referenced
this pull request
Dec 28, 2018
Revendor firecracker go sdk for Firecracker 0.12.0 API changes git shortlog 9614612 (HEAD -> master, origin/master, origin/HEAD) Merge pull request 653c342 Adding drives builder 3c1f5c3 Merge pr kata-containers#41 c4151ff Migrate firectl to its own repository 433f262 Merge pull request kata-containers#23 from xibz/fifo_logging_file 121ef9a add handler lists to handle initialization 0fd9825 Adding support for capturing fifo logs to file. 6b08ec7 Merge branch 'fc-0.12.0' 25878e7 Update for Firecracker 0.12.0 API changes ea93f77 Regenerate API client from swagger spec 00d8eee Update swagger.yaml for firecracker 0.12.0 Signed-off-by: Manohar Castelino <[email protected]>
zklei
pushed a commit
to zklei/runtime
that referenced
this pull request
Jun 13, 2019
This commit turns the agent into a subreaper, in order to reap all the processes started from any container. This is the only way to make sure we won't end up with some zombies processes in case we have some child processes terminating before their own children. Fixes kata-containers#23 Signed-off-by: Sebastien Boeuf <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that we can use runv repo as git submodule without splitting it.