This repository has been archived by the owner on May 12, 2021. It is now read-only.
qemu: add disable_image_nvdimm option #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
Codecov Report
@@ Coverage Diff @@
## master #2373 +/- ##
==========================================
+ Coverage 50.05% 50.12% +0.06%
==========================================
Files 112 112
Lines 16131 16171 +40
==========================================
+ Hits 8074 8105 +31
- Misses 7043 7048 +5
- Partials 1014 1018 +4 |
|
@Pennyzct The |
|
@bergwolf thanks for the explanation. ;) |
jodh-intel
approved these changes
Dec 24, 2019
There was a problem hiding this comment.
Thanks @bergwolf!
lgtm
We should create an integration test for this in https://github.com/kata-containers/tests/ though too I think.
Do not implement in each arch code. We should have a generic implementation instead. -. amd64 and arm64 uses nvdimm -. ppc64le and s390x uses virtio-blk Signed-off-by: Peng Tao <[email protected]>
To control whether an image rootfs is used as nvdimm device or just plain virtio-block device. Fixes: kata-containers#2372 Signed-off-by: Peng Tao <[email protected]>
ret is uintptr and always >= 0. errno is enough for error checking.
This is causing lint error:
/home/vagrant/workplace/golang/src/github.com/kata-containers/runtime/virtcontainers/utils
cli/kata-check.go:446:20: SA4003: no value of type uintptr is less than 0 (staticcheck)
if errno != 0 || ret <= 0 {
^
Signed-off-by: Peng Tao <[email protected]>
So that users can use annotations to set it. Signed-off-by: Peng Tao <[email protected]>
bergwolf
changed the title
|
/test |
Pennyzct
approved these changes
Dec 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To control whether an image rootfs is used as nvdimm device or just plain virtio-block device.