This repository has been archived by the owner on May 12, 2021. It is now read-only.
release: Kata Containers 1.11.0 #2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- clh: backport: Move to v0.7.0 - backport 1.11: fix podman vfio 2d25165 clh: vsock: Supply the right VsockConfig to Vmconfig fcc9e93 versions: Move to cloud-hypervisor v0.7.0 34be9e0 clh: memory: remove pmem size argument 9798e8a versions: Move to latest cloud-hypervisor 93b1b83 virtcontainers: constrain runtime after creating network fc9be99 virtcontainers: update sandbox's device cgroup 5cfae21 virtcontainers: remove all the code related to HasCRIContainerType cff5392 virtcontainers: apply constraints to the sandbox cgroup ce6edc5 pkg/cgroups: update the list of devices for the hypervisor 3fceece pkg/cgroups: add methods to add and remove device from the cgroup b345855 pkg/cgroups: implement functions to get information from a host device 0d3b697 device: add GetHostPath() to generic device Signed-off-by: katacontainersbot <[email protected]>
|
/test-ubuntu |
|
Keeps failing kata-env without any useful information |
|
/test-ubuntu |
2 similar comments
|
/test-ubuntu |
|
/test-ubuntu |
Codecov Report
@@ Coverage Diff @@
## stable-1.11 #2668 +/- ##
===============================================
- Coverage 50.47% 50.43% -0.05%
===============================================
Files 118 118
Lines 17081 17085 +4
===============================================
- Hits 8622 8617 -5
- Misses 7407 7414 +7
- Partials 1052 1054 +2 |
|
I have skip the run of kata-env than unit test find an panic I fixed in ths PR, I am not sure what caused the panic. Now the kata-env command worked and this is the output |
GabyCT
approved these changes
May 8, 2020
amshinde
reviewed
May 8, 2020
| @@ -170,7 +176,7 @@ func constructVersionInfo(version string) VersionInfo { | |||
| Major: sv.Major, | |||
| Minor: sv.Minor, | |||
| Patch: sv.Patch, | |||
| Commit: pres[1], | |||
| Commit: pres, | |||
There was a problem hiding this comment.
This seems the likely cause of failure. Maybe the commit is missing for some reason?
For stable versions the format used `x.y.z`. kata-env was failing trying to make a new release from 1.11.0-rc to 1.11.0 This fix kata-env for releases 1.11+ where this regression was introduced. Fixes: kata-containers#2674 Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
|
/test-ubuntu |
chavafg
approved these changes
May 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2d25165 clh: vsock: Supply the right VsockConfig to Vmconfig
fcc9e93 versions: Move to cloud-hypervisor v0.7.0
34be9e0 clh: memory: remove pmem size argument
9798e8a versions: Move to latest cloud-hypervisor
93b1b83 virtcontainers: constrain runtime after creating network
fc9be99 virtcontainers: update sandbox's device cgroup
5cfae21 virtcontainers: remove all the code related to HasCRIContainerType
cff5392 virtcontainers: apply constraints to the sandbox cgroup
ce6edc5 pkg/cgroups: update the list of devices for the hypervisor
3fceece pkg/cgroups: add methods to add and remove device from the cgroup
b345855 pkg/cgroups: implement functions to get information from a host device
0d3b697 device: add GetHostPath() to generic device
Signed-off-by: katacontainersbot [email protected]