This repository has been archived by the owner on May 12, 2021. It is now read-only.
shimv2: fix the issue of close IO stream (backport from 2.0) #2885
+70
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should wait until the stdin io copy termianted to close the process's io stream, otherwise, it would miss forwarding some contents to process stdin. Fixes: kata-containers#2884 Signed-off-by: fupan.lfp <[email protected]>
|
/test |
fidencio
approved these changes
Aug 11, 2020
Codecov Report
@@ Coverage Diff @@
## master #2885 +/- ##
==========================================
+ Coverage 51.19% 51.20% +0.01%
==========================================
Files 118 118
Lines 17392 17407 +15
==========================================
+ Hits 8903 8913 +10
- Misses 7408 7413 +5
Partials 1081 1081 |
jodh-intel
approved these changes
Aug 13, 2020
|
Hi @chavafg Can you take a look on the failed CI? It seems they were not related with this PR. |
|
We can ignore sles and arm jobs, /cc @jcvenegas for clh metrics job and /cc @devimc for vfio job. |
|
restarting vfio job |
1 similar comment
|
restarting vfio job |
|
Hi @devimc |
|
vfio failure is unrelated. Let's merge it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should wait until the stdin io copy
termianted to close the process's io stream,
otherwise, it would miss forwarding some contents
to process stdin.
Fixes: #2884
Signed-off-by: fupan.lfp [email protected]