This repository has been archived by the owner on May 12, 2021. It is now read-only.
virtcontainers: Reduce path lengths #294
Merged
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce the virtcontainers prefix path to avoid hitting the 107 byte Unix domain socket path limit. Related kata-containers#268. Fixes kata-containers#290. Signed-off-by: James O. D. Hunt <[email protected]>
|
With this change: Saving |
Codecov Report
@@ Coverage Diff @@
## master #294 +/- ##
=======================================
Coverage 64.53% 64.53%
=======================================
Files 86 86
Lines 8397 8397
=======================================
Hits 5419 5419
Misses 2404 2404
Partials 574 574
Continue to review full report at Codecov.
|
|
Ping @egernst, @jcvenegas, @devimc, @bergwolf. |
egernst
approved these changes
May 9, 2018
egernst
approved these changes
May 9, 2018
jodh-intel
added a commit
to jodh-intel/ksm-throttler
that referenced
this pull request
May 29, 2018
Update for the new Virtcontainers root directory. See: - kata-containers/runtime#200 - kata-containers/runtime#294 Fixes kata-containers#37. Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel
added a commit
to jodh-intel/ksm-throttler
that referenced
this pull request
Jun 5, 2018
Update for the new Virtcontainers root directory. See: - kata-containers/runtime#200 - kata-containers/runtime#294 Fixes kata-containers#37. Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel
added a commit
to jodh-intel/ksm-throttler
that referenced
this pull request
Sep 10, 2018
Update for the new Virtcontainers root directory. See: - kata-containers/runtime#200 - kata-containers/runtime#294 Fixes kata-containers#37. Signed-off-by: James O. D. Hunt <[email protected]>
zklei
pushed a commit
to zklei/runtime
that referenced
this pull request
Jun 13, 2019
We don't know how much time a sandbox can be paused, hence connection write timeout should be disabled to don't close the connection while the sandbox is paused. The same issue has been fixed in kata-proxy, for katabuiltin proxy, it also needs this fix. fixes kata-containers#294 Signed-off-by: fupan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the virtcontainers prefix path to avoid hitting the 107 byte
Unix domain socket path limit.
Related #268.
Fixes #290.
Signed-off-by: James O. D. Hunt [email protected]