This repository has been archived by the owner on May 12, 2021. It is now read-only.
version: upgrade qemu version to v5.1.0 for arm64 #2990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @edmond-hk , it's really what we need to do. |
|
Please could you also raise a PR to update this for 2.0?: https://github.com/kata-containers/kata-containers/blob/2.0-dev/versions.yaml |
jodh-intel
added
the
needs-forward-port
|
/test |
Codecov Report
@@ Coverage Diff @@
## master #2990 +/- ##
==========================================
+ Coverage 50.26% 50.28% +0.01%
==========================================
Files 119 119
Lines 15762 15767 +5
==========================================
+ Hits 7923 7928 +5
Misses 6758 6758
Partials 1081 1081 |
GabyCT
approved these changes
Sep 28, 2020
|
/test |
edmond-hk
added a commit
to edmond-hk/packaging
that referenced
this pull request
Sep 29, 2020
As Shameer's patch drops the DT mode when add nvdimm support for arm64. This patch enable it back. Adopt Shameer's patch [1] Depends-on: github.com/kata-containers/runtime#2990 Fixes: kata-containers#1148 Signed-off-by: Edmond AK Dantes <[email protected]> [1] https://patchwork.kernel.org/patch/11174981/
|
|
/test |
|
Hi @edmond-hk , vxhs has been deprecated from qemu-5.1, so you should also remove "--disable-vxhs" in configure file at https://github.com/kata-containers/packaging/blob/7ce333b69dd7d0cf2bbc85de38826095081530d5/scripts/configure-hypervisor.sh#L376 when qemu version is great than 5.1. |
edmond-hk
added a commit
to edmond-hk/packaging
that referenced
this pull request
Sep 30, 2020
As Shameer's patch drops the DT mode when add nvdimm support for arm64. This patch enable it back. Adopt Shameer's patch [1] remove qemu-aarch64 under obs-packaging and move qemu patch under qemu/patch/5.1.x Depends-on: github.com/kata-containers/runtime#2990 Fixes: kata-containers#1148 Signed-off-by: Edmond AK Dantes <[email protected]> [1] https://patchwork.kernel.org/patch/11174981/
edmond-hk
added a commit
to edmond-hk/packaging
that referenced
this pull request
Sep 30, 2020
As Shameer's patch drops the DT mode when add nvdimm support for arm64. This patch enable it back. Adopt Shameer's patch [1] remove qemu-aarch64 under obs-packaging and move qemu patch under qemu/patch/5.1.x Depends-on: github.com/kata-containers/runtime#2990 Depends-on: github.com/kata-containers/tests#2907 Fixes: kata-containers#1148 Signed-off-by: Edmond AK Dantes <[email protected]> [1] https://patchwork.kernel.org/patch/11174981/
edmond-hk
added a commit
to edmond-hk/tests
that referenced
this pull request
Sep 30, 2020
As obs-packaging has been removed, new patch path should be set. Depends-on: github.com/kata-containers/runtime#2990 Depends-on: github.com/kata-containers/packaging#1149 Fixes: kata-containers#2906 Signed-off-by: Edmond AK Dantes <[email protected]>
Now, the qemu version used in arm is so old. As some new features have merged in current qemu, so it's time to upgrade it. Fixes: kata-containers#2989 Signed-off-by: Edmond AK Dantes <[email protected]>
|
hello @jodh-intel @amshinde, help trigger the tests, thanks. |
|
/test |
jongwu
added a commit
to jongwu/packaging
that referenced
this pull request
Oct 8, 2020
As qemu has upgrade to 5.1 on arm, default config file should update accordingly. Depends-on: github.com/kata-containers/runtime#2990 Fixes: kata-containers#1157 Signed-off-by: Jianyong Wu <[email protected]>
|
@edmond-hk the ARM CI is failing with installing QEMU |
|
for the |
|
Hi @devimc , I have open PR kata-containers/packaging#1158 to fix this, so we can test ARM CI there depends on this PR. |
|
thanks @jongwu - restarting ARM CI |
|
@devimc -, ARM CI fail for |
|
forward port PR: kata-containers/kata-containers#817 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, the qemu version used in arm is so old. As some new features have merged
in current qemu, so it's time to upgrade it.
Fixes: #2989
Signed-off-by: Edmond AK Dantes [email protected]
@jon @liwei