This repository has been archived by the owner on May 12, 2021. It is now read-only.
docs: Add missing standard docs #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
|
one more approve is required. And the travis failed, looks should not include submodule changes, right? @jodh-intel |
|
@jodh-intel Why are we modifying the runtime submodules? |
|
@sameo - to pull in the latest changes from our runtime. I thought we had tentatively considered doing this after each release? |
|
@jodh-intel Fine with me, but this should be a separate PR. |
|
@jodh-intel And we should let the Hyper team decide when to update the runv code, obviously. |
|
@sameo - oooh sorry, I must have done a |
Add a README, along with the standard code of conduct and contributing docs. Fixes kata-containers#29. Signed-off-by: James O. D. Hunt <[email protected]>
|
LGTM |
zklei
pushed a commit
to zklei/runtime
that referenced
this pull request
Jun 13, 2019
This commit adds a makefile in order to simplify the build commands. Fixes kata-containers#30 Signed-off-by: Sebastien Boeuf <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a README, along with the standard code of conduct and contributing
docs.
Fixes #29.
Signed-off-by: James O. D. Hunt [email protected]