This repository has been archived by the owner on May 12, 2021. It is now read-only.
config: Error if image+initrd specified #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you build and install the runtime, the config file will contain an entry for both an `initrd=` and an `image=` entry. The Developer Guide explains that the user must disable one but it is easy to forget. Modified the runtime to fail if both an image and an initrd are specified. Also added a new test for this scenario. Fixes kata-containers#318. Signed-off-by: James O. D. Hunt <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
==========================================
+ Coverage 63.87% 63.89% +0.02%
==========================================
Files 87 87
Lines 8620 8623 +3
==========================================
+ Hits 5506 5510 +4
+ Misses 2530 2529 -1
Partials 584 584
Continue to review full report at Codecov.
|
|
IMO runtime shouldn't fail if both are specified, we should take one and print a warning |
|
if you ask me which one is the best, I'll tell you |
sboeuf
approved these changes
May 18, 2018
zklei
pushed a commit
to zklei/runtime
that referenced
this pull request
Jun 13, 2019
agent: enable memory hierarchical account
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you build and install the runtime, the config file will contain an
entry for both an
initrd=and animage=entry.The Developer Guide explains that the user must disable one but it is
easy to forget.
Modified the runtime to fail if both an image and an initrd are
specified. Also added a new test for this scenario.
Fixes #318.
Signed-off-by: James O. D. Hunt [email protected]