virtcontainers: fix codes misunderstanding in virtcontainers #326
Conversation
|
PSS Measurement: Memory inside container: |
Codecov Report
@@ Coverage Diff @@
## master #326 +/- ##
=======================================
Coverage 63.87% 63.87%
=======================================
Files 87 87
Lines 8620 8620
=======================================
Hits 5506 5506
Misses 2530 2530
Partials 584 584
Continue to review full report at Codecov.
|
virtcontainers/api.go
Outdated
| @@ -39,13 +39,13 @@ func CreateSandbox(sandboxConfig SandboxConfig) (VCSandbox, error) { | |||
| } | |||
|
|
|||
| func createSandboxFromConfig(sandboxConfig SandboxConfig) (*Sandbox, error) { | |||
| // Create the sandbox. | |||
| // Create the s. | |||
There was a problem hiding this comment.
Please keep sandbox in the comment
virtcontainers/api.go
Outdated
| s, err := createSandbox(sandboxConfig) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| // Create the sandbox network | ||
| // Create the s network |
virtcontainers/api.go
Outdated
| @@ -60,7 +60,7 @@ func createSandboxFromConfig(sandboxConfig SandboxConfig) (*Sandbox, error) { | |||
| return nil, err | |||
| } | |||
|
|
|||
| // The sandbox is completely created now, we can store it. | |||
| // The s is completely created now, we can store it. | |||
There was a problem hiding this comment.
sry for that using refactor in Goland IDE and it did silly thing...
|
PSS Measurement: Memory inside container: |
virtcontainers/api.go
Outdated
| @@ -129,27 +129,27 @@ func StartSandbox(sandboxID string) (VCSandbox, error) { | |||
| defer unlockSandbox(lockFile) | |||
|
|
|||
| // Fetch the sandbox from storage and create it. | |||
| p, err := fetchSandbox(sandboxID) | |||
| sandbox, err := fetchSandbox(sandboxID) | |||
There was a problem hiding this comment.
Please use s to be consistent with other places.
There was a problem hiding this comment.
There are still some sandbox not s in functions like StatusSandbox.May be I should change them to s
@bergwolf What do you think?
Still there are some codes left which will cause some misunderstanding Change `p` in short of `pod` into `s` or `sandbox` Fixes: #325 Signed-off-by: Haomin <[email protected]>
|
PSS Measurement: Memory inside container: |
|
Since this pr only includes rename, merge it regardless of codecov. |
Still there are some codes left which
will cause some misunderstanding
Change
pin short ofpodintosorsandboxFixes: #325
Signed-off-by: Haomin [email protected]