Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

cli: add no-pivot flag to be compatible with docker in ramdisk #423

Merged
merged 1 commit into from
Jun 20, 2018
Merged

cli: add no-pivot flag to be compatible with docker in ramdisk #423

merged 1 commit into from
Jun 20, 2018

Conversation

wwq2333
Copy link
Contributor

@wwq2333 wwq2333 commented Jun 20, 2018

This commit add a no-pivot flag (just a warning tip) in kata-runtime create and run cmd.

Fixes: #409 , #134

Signed-off-by: wenqi wang [email protected]

@wwq2333 wwq2333 mentioned this pull request Jun 20, 2018
Closed
@wwq2333
Copy link
Contributor Author

wwq2333 commented Jun 20, 2018 •
edited
Loading

This is the update of #412 .

I delete my repository, and can't commit again.
so sorry, it's my first time to submit PR on GitHub and it is not standard enough.

@katacontainersbot
Copy link
Contributor

PSS Measurement:
Qemu: 144806 KB
Proxy: 4708 KB
Shim: 9058 KB

Memory inside container:
Total Memory: 2045972 KB
Free Memory: 2007308 KB

@jshachm
Copy link
Member

jshachm commented Jun 20, 2018

@wwq19920405 There are two commits. One is about fixes gofmt. Can we make them into just one commit. Or maybe you just want to do git commit --amend and sth went wrong^_^

cli: add no-pivot flag to be compatible with docker in ramdisk
6b496e4 
This commit add a no-pivot flag (just a warning tip) in kata-runtime create and run cmd.

Fixes: kata-containers#409 , kata-containers#134

Signed-off-by: wenqi wang [email protected]
@codecov
Copy link

codecov bot commented Jun 20, 2018 •
edited
Loading

Codecov Report

Merging #423 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #423   +/-   ##
=======================================
  Coverage   63.77%   63.77%           
=======================================
  Files          87       87           
  Lines        8823     8823           
=======================================
  Hits         5627     5627           
  Misses       2592     2592           
  Partials      604      604
Impacted Files Coverage Δ
cli/run.go 88.23% <ø> (ø) ⬆️
cli/create.go 79.39% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f102f8...6b496e4. Read the comment docs.

@wwq2333
Copy link
Contributor Author

wwq2333 commented Jun 20, 2018

done

@katacontainersbot
Copy link
Contributor

PSS Measurement:
Qemu: 146973 KB
Proxy: 4766 KB
Shim: 8848 KB

Memory inside container:
Total Memory: 2045972 KB
Free Memory: 2007424 KB

@WeiZhang555
Copy link
Member

WeiZhang555 commented Jun 20, 2018 •
edited by amshinde
Loading

LGTM

Approved with PullApprove

@gnawux
Copy link
Member

gnawux commented Jun 20, 2018 •
edited by amshinde
Loading

+1

Welcome the contribution during Hackthon Beijing.

Approved with PullApprove

@gnawux gnawux merged commit c324b55 into kata-containers:master Jun 20, 2018
@wwq2333 wwq2333 mentioned this pull request Jul 26, 2018
Closed
@caoruidong caoruidong mentioned this pull request Nov 20, 2018
Closed
lifupan pushed a commit to lifupan/kata-runtime that referenced this pull request Aug 5, 2020
@bergwolf
Merge pull request kata-containers#423 from cmaf/unit-virtcontainers-…
c5c3f5c 
…bridges

virtcontainers: Add to bridges unit test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wwq2333 @katacontainersbot @jshachm @WeiZhang555 @gnawux