build: fix breaking 1.8.3 build #662

WeiZhang555 · 2018-08-29T11:36:38Z

Fixes #638

Latest kata-runtime can't build with golang 1.8.3, fix it for backward compatibility.

Signed-off-by: Wei Zhang [email protected]

WeiZhang555 · 2018-08-29T11:37:27Z

Golang version is bumped in another PR: #643

katacontainersbot · 2018-08-29T11:47:30Z

PSS Measurement:
Qemu: 167167 KB
Proxy: 4148 KB
Shim: 8763 KB

Memory inside container:
Total Memory: 2043464 KB
Free Memory: 2003440 KB

opendev-zuul · 2018-08-29T12:18:38Z

Build failed (third-party-check pipeline) integration testing with
OpenStack. For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

kata-runsh : FAILURE in 39m 55s

jodh-intel · 2018-08-29T13:05:30Z

Nice!

lgtm

jodh-intel · 2018-08-29T13:08:08Z

Ugh - another Clear Linux guest kernel crash on 16.04 CI:

time="2018-08-29T12:16:37.88774631Z" level=info msg="[    5.065088] run queue from wrong CPU 2, hctx active
" name=kata-proxy pid=6966 sandbox=a49ca4fbae25bf0f6b4f782c6627320764b474135f965d5f6c4f03244d485bbd source=agent
time="2018-08-29T12:16:37.888305717Z" level=info msg="[    5.065371] CPU: 2 PID: 205 Comm: kworker/2:1H Not tainted 4.14.51-135.container #1
" name=kata-proxy pid=6966 sandbox=a49ca4fbae25bf0f6b4f782c6627320764b474135f965d5f6c4f03244d485bbd source=agent
time="2018-08-29T12:16:37.88874082Z" level=info msg="[    5.065946] Workqueue: kblockd blk_mq_run_work_fn
" name=kata-proxy pid=6966 sandbox=a49ca4fbae25bf0f6b4f782c6627320764b474135f965d5f6c4f03244d485bbd source=agent
time="2018-08-29T12:16:37.889037597Z" level=info msg="[    5.066047] Call Trace:
" name=kata-proxy pid=6966 sandbox=a49ca4fbae25bf0f6b4f782c6627320764b474135f965d5f6c4f03244d485bbd source=agent
time="2018-08-29T12:16:37.889425584Z" level=info msg="[    5.066047]  dump_stack+0x5c/0x81
" name=kata-proxy pid=6966 sandbox=a49ca4fbae25bf0f6b4f782c6627320764b474135f965d5f6c4f03244d485bbd source=agent
time="2018-08-29T12:16:37.889854915Z" level=info msg="[    5.066047]  __blk_mq_run_hw_queue+0xc5/0xd0
" name=kata-proxy pid=6966 sandbox=a49ca4fbae25bf0f6b4f782c6627320764b474135f965d5f6c4f03244d485bbd source=agent
time="2018-08-29T12:16:37.890201577Z" level=info msg="[    5.066047]  process_one_work+0x110/0x320
" name=kata-proxy pid=6966 sandbox=a49ca4fbae25bf0f6b4f782c6627320764b474135f965d5f6c4f03244d485bbd source=agent
time="2018-08-29T12:16:37.890556646Z" level=info msg="[    5.066047]  worker_thread+0x42/0x430
" name=kata-proxy pid=6966 sandbox=a49ca4fbae25bf0f6b4f782c6627320764b474135f965d5f6c4f03244d485bbd source=agent
time="2018-08-29T12:16:37.890887844Z" level=info msg="[    5.066047]  kthread+0xf2/0x130
" name=kata-proxy pid=6966 sandbox=a49ca4fbae25bf0f6b4f782c6627320764b474135f965d5f6c4f03244d485bbd source=agent
time="2018-08-29T12:16:37.891281248Z" level=info msg="[    5.066047]  ? process_one_work+0x320/0x320
" name=kata-proxy pid=6966 sandbox=a49ca4fbae25bf0f6b4f782c6627320764b474135f965d5f6c4f03244d485bbd source=agent
time="2018-08-29T12:16:37.891711079Z" level=info msg="[    5.066047]  ? kthread_create_on_node+0x40/0x40
" name=kata-proxy pid=6966 sandbox=a49ca4fbae25bf0f6b4f782c6627320764b474135f965d5f6c4f03244d485bbd source=agent
time="2018-08-29T12:16:37.892094479Z" level=info msg="[    5.066047]  ? do_page_fault+0x2d/0x90
" name=kata-proxy pid=6966 sandbox=a49ca4fbae25bf0f6b4f782c6627320764b474135f965d5f6c4f03244d485bbd source=agent
time="2018-08-29T12:16:37.892418472Z" level=info msg="[    5.066047]  ret_from_fork+0x35/0x40
" name=kata-proxy pid=6966 sandbox=a49ca4fbae25bf0f6b4f782c6627320764b474135f965d5f6c4f03244d485bbd source=agent

/cc @devimc, @grahamwhaley, @jcvenegas, @miguelinux.

jodh-intel · 2018-08-29T15:30:49Z

The first guest kernel crash I noticed is on #585.

opendev-zuul · 2018-08-30T15:04:54Z

Build failed (third-party-check pipeline) integration testing with
OpenStack. For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

kata-runsh : FAILURE in 27m 27s

katacontainersbot · 2018-08-30T17:21:52Z

PSS Measurement:
Qemu: 169492 KB
Proxy: 4066 KB
Shim: 8796 KB

Memory inside container:
Total Memory: 2043464 KB
Free Memory: 2003572 KB

Fixes kata-containers#638. Latest kata-runtime can't build with golang 1.8.3, fix it for backward compatibility. Signed-off-by: Wei Zhang <[email protected]>

katacontainersbot · 2018-08-31T02:03:32Z

PSS Measurement:
Qemu: 169501 KB
Proxy: 4217 KB
Shim: 8829 KB

Memory inside container:
Total Memory: 2043464 KB
Free Memory: 2003564 KB

codecov · 2018-08-31T02:51:03Z

Codecov Report

❗ No coverage uploaded for pull request base (master@7d14aea). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #662   +/-   ##
=========================================
  Coverage          ?   65.35%           
=========================================
  Files             ?       85           
  Lines             ?     9879           
  Branches          ?        0           
=========================================
  Hits              ?     6456           
  Misses            ?     2766           
  Partials          ?      657

WeiZhang555 · 2018-08-31T02:53:22Z

CI passed. PTAL @jodh-intel @sboeuf @bergwolf @kata-containers/runtime

opendev-zuul · 2018-08-31T03:14:23Z

Build failed (third-party-check pipeline) integration testing with
OpenStack. For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

kata-runsh : TIMED_OUT in 1h 01m 04s

bergwolf · 2018-08-31T07:04:19Z

LGTM

bergwolf · 2018-08-31T07:08:37Z

Well, pullapprove doesn't recognize my approval. I'm going to ignore it as well >.<

sboeuf · 2018-09-12T19:32:45Z

@WeiZhang555 please backport to stable branches.

WeiZhang555 · 2018-09-13T02:17:21Z

branch stable-1.2 doesn't have same issue, this issue is introduced by opentracing feature.

sboeuf · 2018-09-13T04:32:55Z

@WeiZhang555 thanks for the feedback. So no need to backport neither to 1.1 nor to 1.2.

This reverts commit 717ee24. Since most of the runtime unit tests depending on unix socket without yamux, and that commit would break those tests, thus I have to revert this commit. Fixes: kata-containers#662 Signed-off-by: lifupan <[email protected]>

egernst added the review label Aug 29, 2018

WeiZhang555 mentioned this pull request Aug 29, 2018

versions: Bump golang from 1.8.3 to 1.9.7 #643

Merged

WeiZhang555 force-pushed the fix-golang1.8.3 branch from c4e32cf to 0e172b3 Compare August 30, 2018 14:25

build: fix breaking 1.8.3 build

af0c137

Fixes kata-containers#638. Latest kata-runtime can't build with golang 1.8.3, fix it for backward compatibility. Signed-off-by: Wei Zhang <[email protected]>

WeiZhang555 force-pushed the fix-golang1.8.3 branch from 0e172b3 to af0c137 Compare August 31, 2018 01:52

bergwolf approved these changes Aug 31, 2018

View reviewed changes

bergwolf merged commit 4c5fa2d into kata-containers:master Aug 31, 2018

egernst removed the review label Aug 31, 2018

sboeuf added bug Incorrect behaviour stable-candidate labels Sep 12, 2018

sboeuf removed the stable-candidate label Sep 13, 2018

WeiZhang555 deleted the fix-golang1.8.3 branch September 17, 2018 03:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: fix breaking 1.8.3 build #662

build: fix breaking 1.8.3 build #662

WeiZhang555 commented Aug 29, 2018

WeiZhang555 commented Aug 29, 2018

katacontainersbot commented Aug 29, 2018

opendev-zuul bot commented Aug 29, 2018

jodh-intel commented Aug 29, 2018 •

edited by amshinde

Loading

jodh-intel commented Aug 29, 2018

jodh-intel commented Aug 29, 2018

opendev-zuul bot commented Aug 30, 2018

katacontainersbot commented Aug 30, 2018

katacontainersbot commented Aug 31, 2018

codecov bot commented Aug 31, 2018

WeiZhang555 commented Aug 31, 2018 •

edited

Loading

opendev-zuul bot commented Aug 31, 2018

bergwolf commented Aug 31, 2018 •

edited by amshinde

Loading

bergwolf commented Aug 31, 2018

sboeuf commented Sep 12, 2018

WeiZhang555 commented Sep 13, 2018

sboeuf commented Sep 13, 2018

build: fix breaking 1.8.3 build #662

build: fix breaking 1.8.3 build #662

Conversation

WeiZhang555 commented Aug 29, 2018

WeiZhang555 commented Aug 29, 2018

katacontainersbot commented Aug 29, 2018

opendev-zuul bot commented Aug 29, 2018

jodh-intel commented Aug 29, 2018 • edited by amshinde Loading

jodh-intel commented Aug 29, 2018

jodh-intel commented Aug 29, 2018

opendev-zuul bot commented Aug 30, 2018

katacontainersbot commented Aug 30, 2018

katacontainersbot commented Aug 31, 2018

codecov bot commented Aug 31, 2018

Codecov Report

WeiZhang555 commented Aug 31, 2018 • edited Loading

opendev-zuul bot commented Aug 31, 2018

bergwolf commented Aug 31, 2018 • edited by amshinde Loading

bergwolf commented Aug 31, 2018

sboeuf commented Sep 12, 2018

WeiZhang555 commented Sep 13, 2018

sboeuf commented Sep 13, 2018

jodh-intel commented Aug 29, 2018 •

edited by amshinde

Loading

WeiZhang555 commented Aug 31, 2018 •

edited

Loading

bergwolf commented Aug 31, 2018 •

edited by amshinde

Loading