This repository has been archived by the owner on May 12, 2021. It is now read-only.
travis: Add variable needed to run static checks #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we support multiple branches, we changed how static-checks.sh compares branches. We now need a variable called $target_branch to make the correct comparison when testing a PR. Fixes: kata-containers#663. Signed-off-by: Salvador Fuentes <[email protected]>
|
lgtm |
|
Build failed (third-party-check pipeline) integration testing with
|
|
PSS Measurement: Memory inside container: |
Codecov Report
@@ Coverage Diff @@
## master #664 +/- ##
=========================================
Coverage ? 65.35%
=========================================
Files ? 85
Lines ? 9879
Branches ? 0
=========================================
Hits ? 6456
Misses ? 2766
Partials ? 657 |
egernst
pushed a commit
to egernst/runtime
that referenced
this pull request
Feb 9, 2021
We should use an alias for opentracing.Span as this can be changed in the future when we implement other tracing methods. Fixes kata-containers#664 Signed-off-by: Gabriela Cervantes <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we support multiple branches, we changed how
static-checks.sh compares branches. We now need a
variable called $target_branch to make the correct
comparison when testing a PR.
Fixes: #663.
Signed-off-by: Salvador Fuentes [email protected]