This repository has been archived by the owner on May 12, 2021. It is now read-only.
kata-env: Fix display of debug options #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The runtime and hypervisor `Debug` options were always showing as `false` (although all debug options in `configuration.toml` were correctly honoured). Note: Also moved location of `FactoryConfig` in `RuntimeConfig` as the `malign` linter was complaining: ``` virtcontainers/pkg/oci/utils.go:102:20:warning: struct of size 408 could be 400 (maligned) ``` Original-master-commit: https://github.com/kata-containers/runtime/commits/23a35c84c92e6ce73366edc575ae875ba4d77473 Fixes kata-containers#724. Signed-off-by: James O. D. Hunt <[email protected]>
|
LGTM |
|
PSS Measurement: Memory inside container: |
Codecov Report
@@ Coverage Diff @@
## stable-1.2 #738 +/- ##
=============================================
Coverage ? 66.94%
=============================================
Files ? 85
Lines ? 9166
Branches ? 0
=============================================
Hits ? 6136
Misses ? 2393
Partials ? 637 |
egernst
pushed a commit
to egernst/runtime
that referenced
this pull request
Feb 9, 2021
mount: Use "virtiofs" instead of "virtio_fs"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runtime and hypervisor
Debugoptions were always showing asfalse(although all debug options inconfiguration.tomlwerecorrectly honoured).
Note: Also moved location of
FactoryConfiginRuntimeConfigas themalignlinter was complaining:Original-master-commit: https://github.com/kata-containers/runtime/commits/23a35c84c92e6ce73366edc575ae875ba4d77473
Fixes #724.
Signed-off-by: James O. D. Hunt [email protected]