This repository has been archived by the owner on May 12, 2021. It is now read-only.
virtcontainers: revert "fix shared dir resource remaining" #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8a6d383. Don't remove all directories in the shared directory because `docker cp` re-mounts all the mount points specified in the config.json causing serious problems in the host. fixes kata-containers#777 Signed-off-by: Julio Montes <[email protected]>
|
/test |
amshinde
approved these changes
Sep 24, 2018
|
PSS Measurement: Memory inside container: |
Codecov Report
@@ Coverage Diff @@
## master #778 +/- ##
==========================================
+ Coverage 65.31% 65.32% +0.01%
==========================================
Files 87 87
Lines 10622 10611 -11
==========================================
- Hits 6938 6932 -6
+ Misses 2986 2982 -4
+ Partials 698 697 -1 |
|
re-starting jenkins-ci-fedora-27 |
|
lgtm |
|
Need find another way to do the clean up. Will do it later~ @amshinde |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8a6d383.
Don't remove all directories in the shared directory because
docker cpre-mounts all the mount points specified in theconfig.json causing serious problems in the host.
fixes #777
Signed-off-by: Julio Montes [email protected]