This repository has been archived by the owner on May 12, 2021. It is now read-only.
factory: use customised deep compare #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reflect.DeepEqual would return false when comparing nil map/slice with empty map/slice. We would want to return success in such case, since it is possible for upper layers to send these kind of configs. Fixes: kata-containers#844 Signed-off-by: Peng Tao <[email protected]>
|
/test |
jodh-intel
reviewed
Oct 19, 2018
| @@ -100,6 +100,71 @@ func resetHypervisorConfig(config *vc.VMConfig) { | |||
| config.ProxyConfig = vc.ProxyConfig{} | |||
| } | |||
|
|
|||
| func compareStruct(foo, bar reflect.Value) bool { | |||
| for i := 0; i < foo.NumField(); i++ { | |||
There was a problem hiding this comment.
Missing check on field counts for foo and bar? They might compare as the same but if bar has extra fields that would be incorrect surely?
There was a problem hiding this comment.
They have to pass foo.Type() == bar.Type() so they must be of the same struct type.
Codecov Report
@@ Coverage Diff @@
## master #845 +/- ##
=========================================
Coverage ? 69.29%
=========================================
Files ? 88
Lines ? 13436
Branches ? 0
=========================================
Hits ? 9310
Misses ? 3240
Partials ? 886 |
|
lgtm |
1 similar comment
|
lgtm |
|
/retest |
|
LGTM CI retriggered, let's see if there's any real issue. |
|
Still seeing network timeouts. /test |
|
CI green now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reflect.DeepEqual would return false when comparing nil map/slice with
empty map/slice. We would want to return success in such case, since it
is possible for upper layers to send these kind of configs.
Fixes: #844